1716515 - OK button in Save File dialog has no active state style

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[joshas]

Attachment: save-file.png

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

Download any file from internet, e.g. Firefox installer from https://www.mozilla.org/en-US/firefox/download/thanks/
Using Fedora 34 with GNOME, Wayland.

Actual results:

OK button in Safe File dialog has no active style when clicking and holding down mouse button. In attached screenshots I'm holding mouse button down on OK and Cancel buttons, notice the different active styles.

Expected results:

OK button should have same active styles as Cancel button and other buttons.

Could this issue be related to fact, that OK button is initially disabled for a few seconds after dialog window opens?

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

This seems intentional since we implemented the active style (see this rule and this native code).

It seems we prioritize the default state over the pressed state, but it's not clear to me why... Perhaps we should just switch those conditions around and remove the :not([default]) bit. Martin?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

I'll send a patch, but maybe it's WONTFIX if the above is for a good reason :)

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1716515 - Let default buttons on GTK have proper hover/active/focus states. r=stransky

Comment 5

[Martin Stránský [:stransky] (ni? me)]

I'd rather use the styles which may be less confusing for users.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f620a1ec1da
Let default buttons on GTK have proper hover/active/focus states. r=stransky

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/3f620a1ec1da