1716551 - Fluent linter: improve detection of apostrophes and double quotes

Status: RESOLVED FIXED

(Core :: Internationalization: Localization, defect)

Description

[Francesco Lodolo [:flod]]

Currently, the linter will throw with a string like this

this-message-has-html-quotes = This is a test <a href="{$url}">link</a>

The first textElement ends with a double quote, triggering TE04. Right now, the regex only searches for a single occurrence of ", we should look for ".+" instead (like we do for single quotes).

On the other hand, an apostrophe used as genitive at the end of a word like in functions' time won't be caught, because we look for `\w'\w'. I can't figure out how to solve this with a regex, but we can clean up the string before checking for this specific rule.

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Bug 1716551 - Improve Fluent linter behavior with single and double quotes, r=dminor

• Don't throw when a placeable is enclosed in double straight quotes
• Catch single quotes used as genitive on plural nouns

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6fddf3227367
Improve Fluent linter behavior with single and double quotes, r=dminor

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/6fddf3227367