Closed
Bug 1716610
Opened 5 years ago
Closed 5 years ago
Slightly confusing help text for GCHashMap
Categories
(Core :: JavaScript: GC, task, P3)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
91 Branch
| Tracking | Status | |
|---|---|---|
| firefox91 | --- | fixed |
People
(Reporter: sfink, Assigned: sfink)
Details
Attachments
(1 file)
I was helping someone with a rooting hazard who read the GCHashMap comment
// itself cause tracing or sweeping to be invoked. For tracing, it must be used
// with Rooted or PersistentRooted, or barriered and traced manually. For
// sweeping, currently it requires an explicit call to <map>.sweep().
as meaning that you need to pass a Rooted into GCHashMap::add(). That interpretation reveals further misunderstandings of what's going on, but a minor change would at least prevent falling off the right path at this particular spot.
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → sphink
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/33b6cad5e3b0
Prevent misinterpretation of GCHashMap + Rooted r=jonco DONTBUILD
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox91:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•