Closed Bug 1716663 Opened 4 years ago Closed 4 years ago

Automatic recompiling of activity-stream-*.css with watch doesn't work with sass

Categories

(Firefox :: New Tab Page, task, P3)

task

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

Attachments

(1 file)

The switch from node-sass to sass resulted in --watch not quite working for content-src/{components,styles} directory structure.

We could wait for https://github.com/sass/dart-sass/issues/1359 to be fixed and update. Or we could move content-src/styles/activity-stream-mac.scss up a level so that watch picks up changes from the descendent components/ directory too.

With https://github.com/sass/dart-sass/issues/1359 duplicate of a wontfixed bug, others have used --load-path to have watch include a parent directory.

Assignee: nobody → edilee
Status: NEW → ASSIGNED
Pushed by elee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c7c230a6297b Get automatic recompiling of activity-stream-*.css working with sass r=pdahiya
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: