1716742 - Flag all windows crashes with a last_error_value set to ERROR_COMMITMENT_LIMIT as OOMs

Status: RESOLVED FIXED

(Socorro :: Signature, task, P2)

Description

[Gabriele Svelto [:gsvelto]]

As per title. We manage to catch some via WER, like this one but it's flagged as an OOM only because it hit the error within our memory allocator. If Firefox hits that error in code we don't control - like Microsoft libraries - then the crash is not flagged as an OOM because it doesn't have the OOMAllocationSize annotation.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

I found a few that I think meet the criteria specified:

crashid	last_error_value	signature
bp-220a1716-f404-42a0-9fb2-79a0c0210707	ERROR_COMMITMENT_LIMIT	mozilla::wr::RenderCompositorD3D11SWGL::TileD3D11::Map
bp-d774279e-3e87-4402-b8e7-551490210710	ERROR_COMMITMENT_LIMIT	mozilla::dom::JSActorManager::ReceiveRawMessage
bp-124804f5-25b0-4486-b03b-131b40210713	ERROR_COMMITMENT_LIMIT	mozilla::wr::RenderCompositorD3D11SWGL::TileD3D11::Map

Looking at the first one, with the patch I've got, the signature changes like this:

app@socorro:/app$ socorro-cmd signature 220a1716-f404-42a0-9fb2-79a0c0210707
Crash id: 220a1716-f404-42a0-9fb2-79a0c0210707
Original: mozilla::wr::RenderCompositorD3D11SWGL::TileD3D11::Map
New:      OOM | unknown | mozilla::wr::RenderCompositorD3D11SWGL::TileD3D11::Map
Same?:    False

It uses OOM | unknown because there's no OOMAllocationSize annotation.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 5822: bug 1716742: mark last_error_value ERROR_COMMITMENT_LEVEL as OOM

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #5822: "bug 1716742: mark last_error_value ERROR_COMMITMENT_LEVEL as OOM" in 7e16961.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

I deployed this to prod in bug #1721613 just now.

I reprocessed 220a1716-f404-42a0-9fb2-79a0c0210707 and the signature changed to OOM | unknown | mozilla::wr::RenderCompositorD3D11SWGL::TileD3D11::Map.

Marking as FIXED.