1716806 - There should be a separator space between radio buttons/checkboxes and their labels/strings

Status: NEW

(Firefox :: PDF Viewer, defect, P3)

Description

[Daniel Bodea [:danibodea]]

Attachment: radio buttons should have some sepparating space before the string.png

Note

• When the user loads the corresponding PDF file, he will notice that the placeholder texts are not being displayed.

Affected versions

• Nightly v91.0a1

Affected platforms

• all

Steps to reproduce

1. Launch browser.
2. Flip the pdfjs.enableXfa to true.
3. Load the attached PDF file.

Expected result

• The placeholder texts from inside the name and date fields are correctly displayed.

Actual result

• The placeholder texts from inside the name and date fields are missing.

Regression range

• Not a recent regression, but an implementation flaw.

Comment 1

[Daniel Bodea [:danibodea]]

Attachment: evince-LINK-1031-0-GOOD.pdf

This issue also occurs here and it has a considerable influence on aesthetics.

Comment 2

[Daniel Bodea [:danibodea]]

Attachment: considerable influence on aesthetics.png

Comment 3

[Daniel Bodea [:danibodea]]

Attachment: 0a18b29d-dd86-45cb-a99d-d1a3a38505ed.pdf

Another example where the labels are too close to the controls.

Comment 4

[Daniel Bodea [:danibodea]]

Attachment: another with labels too close to the control - canada50.png

Comment 5

[Daniel Bodea [:danibodea]]

Attachment: 2b9908fb-aec6-4309-8f2d-383af7f372e7.pdf

This issue is also observed in this PDF.

Comment 6

[Daniel Bodea [:danibodea]]

Attachment: checkbox space in canada 33.png

Comment 7

[Sam Foster [:sfoster] (he/him)]

I'm flagging this as a good-first-bug. It looks like we just need to add some margin in viewer.css. The pref mentioned in comment 0 is already true, so you just need to open attachment 9232832 [details] and inspect the result in devtools' inspector.

To get started, you'll need a working dev environment and a local build of firefox. You can follow the docs here to get that setup. You can leave a comment here on the bug stating your intention to work on it. It will be assigned to you once you submit a patch. If you have questions, feel free to need-info me here (check the "request information from" box on this bug form.)

Comment 8

[Walter K.]

Something along these lines seems to work:

:is(.xfaRight) > :is(.xfaCaption, .xfaCaptionForCheckButton) {
  margin-left: 2px;
}

:is(.xfaLeft) > :is(.xfaCaption, .xfaCaptionForCheckButton) {
  margin-right: 2px;
}

I added the second rule for RTL but could not find samples to test with.

Comment 9

[Joseph Webster]

Hi, I'll be working on this bug and will submit a patch soon.

Comment 10

[Joseph Webster]

Attachment: Use of a Representative.pdf

Comment 11

[Joseph Webster]

Attachment: Verification Documents.pdf

Comment 12

[Joseph Webster]

Attachment: Affadavit for HIC Permit.pdf

Comment 13

[Joseph Webster]

Hi Sam,

I'm having a difficult time reproducing this bug. Unfortunately, I can't access any of the previously attached PDFs, but I was able to find the two Canadian forms that Daniel Bodea shared above (I've attached both). These forms seems to be rendering correctly in my local Firefox build. Do you have any suggestions?

Comment 14

[Calixte Denizet (:calixte)]

You can use the pdf in bug 1721636.
For your information, you must set up pdf.js locally, fix the bug and make a PR:
https://github.com/mozilla/pdf.js/

Comment 15

[Calixte Denizet (:calixte)]

:Joseph, you must:

• get the code: https://github.com/mozilla/pdf.js/?tab=readme-ov-file#getting-the-code
• copy the pdf in bug 1721636 in the directory test/pdfs/, as bug1721638.pdf
• open http://localhost:8888/web/viewer.html?file=/test/pdfs/bug1721638.pdf

Now you can hack on whatever css/js/html file.
Once your patch is ready, you just have to submit a PR and few days after your change will be available in Firefox (we make at least one release per week).

Comment 16

[Joseph Webster]

Thank you for the additional information, Calixte. Much appreciated! My plan is to submit the PR today. I'll let you know if I have any additional questions.

Comment 17

[Joseph Webster]

I just submitted a pull request for this bug. Note: my changes do not address the missing placeholder text.

https://github.com/mozilla/pdf.js/pull/17948

Thanks!

Comment 18

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 19

[Chris Shiohama]

This looks interesting. I would love to be assigned!

Comment 20

[Chris Shiohama]

I found another bug to work on. Clearing needinfo.

Comment 21

[Gautam Panakkal]

I just submitted a pull request and would like to be assigned!

Comment 22

[Calixte Denizet (:calixte)]

:Gautam, as mentioned in the PR review, did you check the output of npx gulp xfatest ?

Comment 23

[Gautam Panakkal]

(In reply to Calixte Denizet (:calixte) from comment #22)

:Gautam, as mentioned in the PR review, did you check the output of npx gulp xfatest ?

I did - just replied in the PR with details.

Comment 24

[Stephanie Cunnane [:scunnane]]

I'm removing the previous assignee, as I'm not sure he's working on this any longer. A new contributor will be working on this patch instead.

Comment 25

[[:Joe Cardoso] Loan de Deus Vieira Cardoso]

Hi all,

I'll be contributing to this patch.

Thanks!

Comment 26

[BMO Github Automation]

Attachment: [mozilla/pdf.js] Bug 1716806 - There should be a separator space between radio buttons… (#20437)

Comment 27

[[:Joe Cardoso] Loan de Deus Vieira Cardoso]

I just submitted a pull request and would appreciate some feedback!

Thanks!

Comment 28

[BMO Github Automation]

Attachment: [mozilla/pdf.js] Bug 1716806 - Add separator space between radio buttons/checkboxes an… (#20963)

Comment 29

[japandi]

I've submitted a pull request for this bug: https://github.com/mozilla/pdf.js/pull/20963

The fix adds a non-breaking space before checkbox/radio-button labels in template.js to create the separator space.

Comment 30

[japandi]

(In reply to japandi from comment #29)

I've submitted a pull request for this bug: https://github.com/mozilla/pdf.js/pull/20963

The fix adds a non-breaking space before checkbox/radio-button labels in template.js to create the separator space.