Closed Bug 1716924 Opened 3 years ago Closed 3 years ago

"The Network panel has crashed. File Bug Report" always displayed for any site

Categories

(DevTools :: Netmonitor, defect, P2)

Product:
DevTools
Component:
Netmonitor
Version:
Firefox 90
Type:
defect

Tracking

(firefox91 fixed)

Status:
RESOLVED FIXED
Milestone:
91 Branch
Tracking Flags:
Tracking Status
firefox91 --- fixed

People

(Reporter: tenninjas, Assigned: bomsy)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1716924 - [devtools] Make sure the intersectionObserver is available before disconnecting r=honza
48 bytes, text/x-phabricator-request
Details | Review

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

  1. Open DevTools (new tab or existing does not matter)
  2. Change to Network tab
  3. Load/Reload any site

Actual results:

"The Network panel has crashed."

[button: File Bug Report]

TypeError: can't access property "disconnect", this.intersectionObserver is null

React Component Stack

componentStack

in RequestListContent

in VisibilityHandler

in Unknown

in Connect(Component)

in div

in RequestList

in div

in div

in SplitBox

in div

in div

in SplitBox

in div

in MonitorPanel

in VisibilityHandler

in Unknown

in Connect(Component)

in div

in DropHarHandler

in AppErrorBoundary

in div

in App

in VisibilityHandler

in Unknown

in Connect(Component)

in Provider
Stacktrace

componentWillUnmount@resource://devtools/client/netmonitor/src/components/request-list/RequestListContent.js:168:5

callComponentWillUnmountWithTimer@resource://devtools/client/shared/vendor/react-dom.js:12816:12

safelyCallComponentWillUnmount@resource://devtools/client/shared/vendor/react-dom.js:12824:40

commitUnmount@resource://devtools/client/shared/vendor/react-dom.js:13147:41

commitNestedUnmounts@resource://devtools/client/shared/vendor/react-dom.js:13178:18

unmountHostComponents@resource://devtools/client/shared/vendor/react-dom.js:13439:27

commitDeletion@resource://devtools/client/shared/vendor/react-dom.js:13498:26

commitAllHostEffects@resource://devtools/client/shared/vendor/react-dom.js:14142:25

commitRoot@resource://devtools/client/shared/vendor/react-dom.js:14344:9

completeRoot/<@resource://devtools/client/shared/vendor/react-dom.js:15731:15

unstable_runWithPriority@resource://devtools/client/shared/vendor/react.js:617:12

completeRoot@resource://devtools/client/shared/vendor/react-dom.js:15730:27

performWorkOnRoot@resource://devtools/client/shared/vendor/react-dom.js:15659:21

performWork@resource://devtools/client/shared/vendor/react-dom.js:15567:24

performSyncWork@resource://devtools/client/shared/vendor/react-dom.js:15541:14

requestWork@resource://devtools/client/shared/vendor/react-dom.js:15410:5

scheduleWork@resource://devtools/client/shared/vendor/react-dom.js:15224:16

enqueueSetState@resource://devtools/client/shared/vendor/react-dom.js:8192:17

Component.prototype.setState@resource://devtools/client/shared/vendor/react.js:328:16

onStateChange@resource://devtools/client/shared/vendor/react-redux.js:1412:16

notify@resource://devtools/client/shared/vendor/react-redux.js:1159:21

notifyNestedSubs@resource://devtools/client/shared/vendor/react-redux.js:1198:20

onStateChange@resource://devtools/client/shared/vendor/react-redux.js:1409:16

dispatch@resource://devtools/client/shared/vendor/redux.js:265:7

waitUntilService/</<@resource://devtools/client/shared/redux/middleware/wait-service.js:59:24

eventTelemetryMiddleware/</</<@resource://devtools/client/netmonitor/src/middleware/event-telemetry.js:29:21

throttlingMiddleware/</</<@resource://devtools/client/netmonitor/src/middleware/throttling.js:18:21

recordingMiddleware/</</<@resource://devtools/client/netmonitor/src/middleware/recording.js:24:21

flushActions@resource://devtools/client/netmonitor/src/middleware/batching.js:88:11

DelayedTask/this._promise</this.runTask@resource://devtools/client/netmonitor/src/middleware/batching.js:107:9

notify@resource://gre/modules/Timer.jsm:62:17

Close and reopen the toolbox to clear this error.

Expected results:

Network Panel should operate normally.

This may not may not have relationship to previously closed bug 1685459.

NB: This is occuring in Developer Edition.

BuildID=20210615190254
Milestone=90.0
SourceRepository=https://hg.mozilla.org/releases/mozilla-beta
SourceStamp=6f989625981a918ee8afeef2edb6b37c63475e85

Thanks for the report.

This may not may not have relationship to previously closed bug 1685459.
This looks slightly different.

The stacktrace will allow us prevent the crash.

Would you be able to provide an STR , which would also help track the underlying issue.

Flags: needinfo?(tenninjas)

I included the stack trace in the original report; here is another which should be more readable.

componentWillUnmount@resource://devtools/client/netmonitor/src/components/request-list/RequestListContent.js:168:5
callComponentWillUnmountWithTimer@resource://devtools/client/shared/vendor/react-dom.js:12816:12
safelyCallComponentWillUnmount@resource://devtools/client/shared/vendor/react-dom.js:12824:40
commitUnmount@resource://devtools/client/shared/vendor/react-dom.js:13147:41
commitNestedUnmounts@resource://devtools/client/shared/vendor/react-dom.js:13178:18
unmountHostComponents@resource://devtools/client/shared/vendor/react-dom.js:13439:27
commitDeletion@resource://devtools/client/shared/vendor/react-dom.js:13498:26
commitAllHostEffects@resource://devtools/client/shared/vendor/react-dom.js:14142:25
commitRoot@resource://devtools/client/shared/vendor/react-dom.js:14344:9
completeRoot/<@resource://devtools/client/shared/vendor/react-dom.js:15731:15
unstable_runWithPriority@resource://devtools/client/shared/vendor/react.js:617:12
completeRoot@resource://devtools/client/shared/vendor/react-dom.js:15730:27
performWorkOnRoot@resource://devtools/client/shared/vendor/react-dom.js:15659:21
performWork@resource://devtools/client/shared/vendor/react-dom.js:15567:24
performSyncWork@resource://devtools/client/shared/vendor/react-dom.js:15541:14
requestWork@resource://devtools/client/shared/vendor/react-dom.js:15410:5
scheduleWork@resource://devtools/client/shared/vendor/react-dom.js:15224:16
enqueueSetState@resource://devtools/client/shared/vendor/react-dom.js:8192:17
Component.prototype.setState@resource://devtools/client/shared/vendor/react.js:328:16
onStateChange@resource://devtools/client/shared/vendor/react-redux.js:1412:16
notify@resource://devtools/client/shared/vendor/react-redux.js:1159:21
notifyNestedSubs@resource://devtools/client/shared/vendor/react-redux.js:1198:20
onStateChange@resource://devtools/client/shared/vendor/react-redux.js:1409:16
dispatch@resource://devtools/client/shared/vendor/redux.js:265:7
waitUntilService/</<@resource://devtools/client/shared/redux/middleware/wait-service.js:59:24
eventTelemetryMiddleware/</</<@resource://devtools/client/netmonitor/src/middleware/event-telemetry.js:29:21
throttlingMiddleware/</</<@resource://devtools/client/netmonitor/src/middleware/throttling.js:18:21
recordingMiddleware/</</<@resource://devtools/client/netmonitor/src/middleware/recording.js:24:21
flushActions@resource://devtools/client/netmonitor/src/middleware/batching.js:88:11
DelayedTask/this._promise</this.runTask@resource://devtools/client/netmonitor/src/middleware/batching.js:107:9
notify@resource://gre/modules/Timer.jsm:62:17
Flags: needinfo?(tenninjas)

I included the stack trace in the original report; here is another which should be more readable.

Sorry if my request was confusing. I didn't need the stackrace again.
I was asking if you had the steps to help us reproduce (STR) the issue.
It will help track the root issue and test the fix.
But If that is not available , no problem.

Thanks

Flags: needinfo?(tenninjas)
Assignee: nobody → hmanilla
Blocks: netmonitor-columns
Severity: -- → S3
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P2

(In reply to Hubert Boma Manilla (:bomsy) from comment #4)

I included the stack trace in the original report; here is another which should be more readable.

Sorry if my request was confusing. I didn't need the stackrace again.
I was asking if you had the steps to help us reproduce (STR) the issue.
It will help track the root issue and test the fix.
But If that is not available , no problem.

Thanks

Ah sorry about that. Steps to reproduce are the very first thing I listed in my initial report as well, here again in case it's needed.

  1. Open DevTools (new tab or existing does not matter)
  2. Change to Network tab
  3. Load/Reload any site

To clarify a bit - by "any site" in step 3, I mean to load or reload any resource for which Network Data should be monitored, in the tab for which DevTools has been opened.

Flags: needinfo?(tenninjas)
Pushed by hmanilla@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/95f31efacb3a
[devtools] Make sure the intersectionObserver is available before disconnecting r=Honza

https://hg.mozilla.org/mozilla-central/rev/95f31efacb3a

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox91: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: