1717155 - Stop storing text node in `DeleteTextTransaction`, `InsertTextTransaction` and `ReplaceTextTransaction` if editor is a `TextEditor`

Status: RESOLVED FIXED

(Core :: DOM: Editor, task)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I've not checked instance size of the transaction, we could reduce the footprint of them if they store dom::Text in derived class of them only when the editor is an HTMLEditor. Otherwise, just stopping storing text node is also fine.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Anyway, we need to fix this for making TextEditor can work after recreating the native anonymous subtree.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1717155 - part 1: Make `TextEditor` use `GetTextNode()` more r=m_kato!

The anonymous <div> of TextEditor has only one Text as its first child.
Therefore, we can make TextEditor simpler to access the Text node.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1717155 - part 2: Make `InsertTextTransaction`, `CompositionTransaction`, `DeleteTextTransaction` and `ReplaceTextTransaction` not store `Text` node if it's for `TextEditor` r=m_kato!

So, Text editor can access the Text node quickly and it's not needed to
be grabbed by a lot of transactions. Additionally, when we support keeping
TextEditor instance even if the text control is reflowed (bug 1922141,
bug 1339052 and bug 1620050), transactions need to work with new anonymous
nodes. Therefore, retrieving Text node of TextEditor each time does make
sense rather than storing the node.

Depends on D240419

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b4beaa4fab1
part 1: Make `TextEditor` use `GetTextNode()` more r=m_kato
https://hg.mozilla.org/integration/autoland/rev/7672cad7ff78
part 2: Make `InsertTextTransaction`, `CompositionTransaction`, `DeleteTextTransaction` and `ReplaceTextTransaction` not store `Text` node if it's for `TextEditor` r=m_kato

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/7b4beaa4fab1
https://hg.mozilla.org/mozilla-central/rev/7672cad7ff78