Closed Bug 1717161 Opened 3 years ago Closed 3 years ago

Clamp perspective() values to 1px for interpolation

Categories

(Core :: Web Painting, defect)

defect

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox-esr91 --- wontfix
firefox91 --- wontfix
firefox92 --- wontfix
firefox93 --- fixed

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

Details

Attachments

(1 obsolete file)

As resolved in https://github.com/w3c/csswg-drafts/issues/6320 perspective() values less than 1px should be clamped to 1px, for rendering and for interpolation.

dbaron added a bunch of new WPTs for this, landed into gecko in bug 1713961.

Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b7e1a728dfd2
Clamp perspective() values to a minimum of 1px. r=emilio

As discussed with dbaron over email, I've made a change to transform-perspective-composition.html to reflect that perspective now gets clamped to 1px.

Flags: needinfo?(matt.woodrow)
Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a1cbf18d246a
Clamp perspective() values to a minimum of 1px. r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/29573 for changes under testing/web-platform/tests
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
Upstream PR merged by moz-wptsync-bot
Regressions: 1722558
Regressions: 1722866
Regressions: 1723266

Given the regressions would it make sense to back this out of 91 so we can address the issues before shipping this change?

Flags: needinfo?(matt.woodrow)

(In reply to Julien Cristau [:jcristau] from comment #10)

Given the regressions would it make sense to back this out of 91 so we can address the issues before shipping this change?

Yeah I think we should back it out and hold it back a cycle while Chrome ships it and we get the spec issue resolved.

Flags: needinfo?(matt.woodrow)
Regressions: 1724661
Regressions: 1725907

Matt, is there some way we can limit the scope of these changes to Nightly only while the various issues get sorted out?

Flags: needinfo?(matt.woodrow)

(In reply to Ryan VanderMeulen [:RyanVM] from comment #13)

Matt, is there some way we can limit the scope of these changes to Nightly only while the various issues get sorted out?

Not super easily unfortunately.

We should probably just back out of beta since the fix hasn't yet landed on Nightly.

Flags: needinfo?(matt.woodrow)
Regressions: 1726030
No longer regressions: 1726030
Attachment #9227816 - Attachment is obsolete: true

Matt, there is still a dependency on a testcase that crashes Firefox (I just tried, it does crash without a crash report). Given that no crash report is sent, I have no idea if this is likely to happen in the wild or if it is limited to this testcase. Do you think that we can let the feature ride to release in 93 or should I back it out as we did in beta 91 and 92? Thanks

Flags: needinfo?(matt.woodrow)

(In reply to Pascal Chevrel:pascalc from comment #16)

Matt, there is still a dependency on a testcase that crashes Firefox (I just tried, it does crash without a crash report). Given that no crash report is sent, I have no idea if this is likely to happen in the wild or if it is limited to this testcase. Do you think that we can let the feature ride to release in 93 or should I back it out as we did in beta 91 and 92? Thanks

I don't think this is really a regression, it's an issue with tiny perspective values and exists already on release.

The change here just clamps perspective(0) to perspective(1px), which affects this test case and makes it exhibit the problematic behaviour. Editing this testcase to have perspective(1px) makes the same problem happen on older releases.

It's possible that this change makes more websites run into this existing issue, but I wouldn't expect it to be very common.

Flags: needinfo?(matt.woodrow)
Regressions: 1734999
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: