1717169 - Collect value of browser.urlbar.showSearchSuggestionsFirst

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P3)

Description

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

We're interested in understanding how many clients have a non-default value for the browser.urlbar.showSearchSuggestionsFirst preference. We used it for targeting in https://experimenter.services.mozilla.com/nimbus/firefox-suggest-v1 and enrollment is somewhat lower than we expected and we think this might be one reason why, and we'd like to confirm or reject that idea.

Comment 1

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Attachment: Bug 1717169 - Collect value of browser.urlbar.showSearchSuggestionsFirst r=chutten

Comment 2

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Attachment: Data collection request

Comment 3

[Travis Long [:travis_]]

Comment on attachment 9227824 [details]
Data collection request

Data Review

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, via the TelemetryEnvironment.jsm

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, normal telemetry opt-out in preferences.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Rebecca BurWei to be responsible for monitoring the permanent collection of this metric.

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, User Interaction

5. Is the data collection request for default-on or default-off?

default-on

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No

7. Is the data collection covered by the existing Firefox privacy notice?

Yes

8. Does the data collection use a third-party collection tool?

No

Result

data-review+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0f81b8214e5
Collect value of browser.urlbar.showSearchSuggestionsFirst r=chutten

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/b0f81b8214e5

Comment 6

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Comment on attachment 9227823 [details]
Bug 1717169 - Collect value of browser.urlbar.showSearchSuggestionsFirst r=chutten

Beta/Release Uplift Approval Request

• User impact if declined: This is a telemetry-only change so there's no direct user impact, but we're interested in understanding whether enrollment is lower than expected in https://experimenter.services.mozilla.com/nimbus/firefox-suggest-v1 because more users than we expected have changed this preference.
  Having this context sooner will help us execute the follow-up experiments that are planned for upcoming releases.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One-line change that extends a list of prefs to collect using a well-tested telemetry mechanism; doesn't introduce or change any logic.
• String changes made/needed: none

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9227823 [details]
Bug 1717169 - Collect value of browser.urlbar.showSearchSuggestionsFirst r=chutten

approved for 90.0b12.

at this point if we have another 89 dot release it'd be a chemspill, though, so a- for release.

Comment 8

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d6d39cef9d49

Comment 9

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Thanks, Julien!