Closed Bug 1717463 Opened 3 years ago Closed 3 years ago

SecuritySettingsCleaner does not clear all partitioned client auth remember decisions

Categories

(Toolkit :: Data Sanitization, defect)

defect

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: pbz, Assigned: pbz)

References

Details

Attachments

(1 file)

The client auth remember service clearing logic currently only looks at the top level host. This means we don't clear partitioned client auth remember decisions for the given base domain.

https://searchfox.org/mozilla-central/rev/308ea44d0d60b391b031ccee695920bd543f7d2f/toolkit/components/cleardata/ClearDataService.jsm#1098-1101

We should also match the partitionKey which is part of the entry key here: https://searchfox.org/mozilla-central/rev/308ea44d0d60b391b031ccee695920bd543f7d2f/security/manager/ssl/nsIClientAuthRememberService.idl#27

Assignee: nobody → pbz
Status: NEW → ASSIGNED
Attachment #9228283 - Attachment description: WIP: Bug 1717463 - Update SecuritySettingsCleaner to clear partitioned client auth remember decisions. r=johannh!,keeler! → Bug 1717463 - Update SecuritySettingsCleaner to clear partitioned client auth remember decisions. r=johannh!,keeler!
Pushed by pzuhlcke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/35d1a8d79d89
Update SecuritySettingsCleaner to clear partitioned client auth remember decisions. r=johannh,keeler
Pushed by malexandru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6f870faf64a9
Add missing semicolon in test_security_settings.js a=lint-fix
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: