1717625 - Hosts are not displayed in storage inspector with disabled server side target switching + bfCacheInParent enabled

Status: RESOLVED FIXED

(DevTools :: Storage Inspector, defect)

Description

[Nicolas Chevobbe [:nchevobbe]]

In Bug 1713072, I had to disable fission.bfcacheInParent as it was making a test fail: we are navigating backward and waiting for the host we're navigating to to be displayed in the storage inspector tree, but it does not.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1717625 - [devtools] Fix storage inspector tree when bfCacheInParent is enabled and server side target switching is disabled. r=ochameau.

In this patch, we pass a property alongside the DevToolsFrameChild:bf-cache-navigation-pageshow
message that indicates if a new target is being created as a result of this
bfcache navigation.
This flag is then used in the ParentProcessStorage to spawn a new StorageActorMock
when a new target is being created.

As a result we can stop disabling the bfCacheInParent pref in browser_storage_cookies_navigation.js,
where a bfcache navigation is performed.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0fbda14ef14
[devtools] Fix storage inspector tree when bfCacheInParent is enabled and server side target switching is disabled. r=ochameau.

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d0fbda14ef14