171769 - [ActiveX] DOM - implement put_InnerHTML and a other simple methods

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: ActiveX Wrapper, defect)

Description

[Adam Lock]

Implement put_innerHTML & investigate IHTMLDocument3. Also investigate why
get_Body might not be returning a valid object.

Comment 1

[Adam Lock]

IHTMLDocument3 isn't in the standard MSDev 6 include path. I'll hold off on this
a while.

Comment 2

[Adam Lock]

Attachment: Patch

Patch implements put_innerHTML, get_lastModified and put_/get_ alinkColor,
vlinkColor, fgColor, bgColor, linkColor. It also fixes a longstanding problem
with the document property dialog which hardcoded "Hypertext Transfer Protocol"
as the document type whether it was or not.

Comment 3

[Chak Nanga]

Comment on attachment 102248 [details] [diff] [review]
Patch

r=chak

Comment 4

[rpotts (gone)]

hey adam,

i took a look at the patch and it looks good.  my only question is whether
the NS_ENSURE_TRUE(...) return NS_ERROR_FAILURE in PageDlg::OnInitDialog() ?  It
looks like the failure code might be 0 in this case?

other than that... sr=[e-mail]

-- rick

Comment 5

[Adam Lock]

Attachment: Patch mk 2

Patch addresses Rick's point

Comment 6

[Adam Lock]

Comment on attachment 102961 [details] [diff] [review]
Patch mk 2

Carrying r & sr forward

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 102961 [details] [diff] [review]
Patch mk 2

a=[e-mail]

Comment 8

[Adam Lock]

Fix checked in