1717838 - Fix fuzz added for bug863728-2.html and bug945215-2.html in dom/encoding/test/reftest/reftest.list for Fission

Status: NEW

(Core :: Graphics: Text, defect, P3)

Description

[Andrew Halberstadt [:ahal]]

The following reftests had fuzzy annotations added due to failures when standing up new configurations:

== bug863728-2.html bug863728-2-ref.html
== bug945215-2.html bug945215-2-ref.html

Here is a diff:

diff --git a/dom/encoding/test/reftest/reftest.list b/dom/encoding/test/reftest/reftest.list
--- a/dom/encoding/test/reftest/reftest.list
+++ b/dom/encoding/test/reftest/reftest.list
@@ -1,5 +1,5 @@
 == bug863728-1.html bug863728-1-ref.html
-fuzzy-if(skiaContent,0-1,0-10) == bug863728-2.html bug863728-2-ref.html
+fuzzy-if(skiaContent,0-1,0-10) fuzzy-if(winWidget&&browserIsFission,47-47,211-211) == bug863728-2.html bug863728-2-ref.html
 == bug863728-3.html bug863728-3-ref.html
 == bug945215-1.html bug945215-1-ref.html
-fuzzy-if(skiaContent,0-1,0-10) == bug945215-2.html bug945215-2-ref.html
+fuzzy-if(skiaContent,0-1,0-10) fuzzy-if(winWidget&&browserIsFission,47-47,211-211) == bug945215-2.html bug945215-2-ref.html

See this try push for failures.

Be sure the patch from bug 1696038 has landed (or you pull it in locally) before attempting to reproduce on try.

Comment 1

[Chris Peterson [:cpeterson]]

Here is a direct link to the reftest analyzer output for these reftest failures:

https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/IpBkd_hWSxWgfQc185-eHg/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

Looks like a pretty minor difference with text layout. Tracking for Fission Future because I don't think this bug needs to block Fission MVP.

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: image.png

Here is a screenshot of the differences in the reftest analyzer for posterity.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Why is that in Core::I18n?

Comment 4

[Chris Peterson [:cpeterson]]

(In reply to Zibi Braniecki [:zbraniecki][:gandalf] from comment #3)

Why is that in Core::I18n?

I think this bug was filed by a script and one of the the affected tests (dom/encoding/test/reftest/bug863728-1-ref.html) was added in an Core::I18n bug (bug 863728).

I will move this to the "Core::Graphics: Text" component since this test failure is probably a graphics issue.