171785 - 6 Assertions in nsStaticNameTable::Init() during startup

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[kinmoz]

I've been seeing 6 assertions on startup:

###!!! ASSERTION: Entry already exists!: 'entry->mKey == 0', file y:/mozilla/xpc
om/ds/nsStaticNameTable.cpp, line 139
Break: at file y:/mozilla/xpcom/ds/nsStaticNameTable.cpp, line 139

ever since the morning of 09/26/02. All having to do with the key "outline".

A quick look at all the checkins between 09/25 and 09/26 with:

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=09%2F25%2F2002+08%3A00%3A00&maxdate=09%2F26%2F2002+08%3A00%3A00&cvsroot=%2Fcvsroot

and it looks like the fix for bug 117500 may be related?

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Fix

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

Yeah this is mine.  Sorry about these.  Actually I think this patch already has
r=dbaron sr=jst since this was in my patch in bug 117500 but for whatever reason
I somehow managed to not check this part in.  The only other change in this
patch is a silly goof of over c&p'ing in the outline properties...

Comment 3

[kinmoz]

Comment on attachment 101165 [details] [diff] [review]
Fix

Yup, this gets rid of the assertions. Thanks!

Comment 4

[[e-mail] (gone - use [e-mail] instead)]

I see the assertions, but I also crash...  Does anybody else crash, or am I
hitting something else?

Comment 5

[kinmoz]

Comment on attachment 101165 [details] [diff] [review]
Fix

Since the original patch used the CSS_PROP_NOTIMPLEMENTED macros for the props
changed in this patch and were r=/sr='d already, I'll give an
r/sr=[e-mail] on the "outline" c&p corrections ... lets get this puppy
in.

stephend, I'm not seeing a crash, just the assertions.

Comment 6

[Boris Zbarsky [:bzbarsky]]

*** Bug 171326 has been marked as a duplicate of this bug. ***

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 101165 [details] [diff] [review]
Fix

r=dbaron

Comment 8

[Christopher Aillon (sabbatical, not receiving bugmail)]

Checked in.  The only thing I can think of is I undid a few changes in the wrong
file by accident, saved without realizing and then didn't notice before landing.
 Anyway, it's been righted now.