Closed Bug 1717851 Opened 4 years ago Closed 4 years ago

Increase max storebuffer size

Categories

(Core :: JavaScript: GC, task)

task

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(1 file)

With the pretenuring changes enabled, the reddit.com pageload test shows a significant number of minor GCs are triggered by the slots storebuffer filling up. This is different to the case where it's disabled where most minor GCs are triggered by the nursery being full.

The whole cell buffer has a maximum size of 128KB but the other buffers have a smaller limit of 48KB.

Increasing the limit to 128KB all around seems to fix the reddit regression on perfherder so let's try that. Note that this is threshold for triggering minor GC, not a fixed sizes that these buffers will occupy.

Assignee: nobody → jcoppeard
Status: NEW → ASSIGNED
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/46105e31ca61 Increase maximum storebuffer size to 128KB all round r=sfink
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: