1717856 - Fix fuzz added for iframe-scrolling-attr-ref.html in layout/reftests/scrolling/reftest.list for Fission

Status: NEW

(Core :: Layout, defect)

Description

[Andrew Halberstadt [:ahal]]

The following reftests had fuzzy annotations added due to failures when standing up new configurations:

== iframe-scrolling-attr-1.html iframe-scrolling-attr-ref.html
== iframe-scrolling-attr-2.html iframe-scrolling-attr-ref.html

Here's the full diff:

diff --git a/layout/reftests/scrolling/reftest.list b/layout/reftests/scrolling/reftest.list
--- a/layout/reftests/scrolling/reftest.list
+++ b/layout/reftests/scrolling/reftest.list
@@ -29,18 +29,18 @@ fuzzy-if(Android,0-4,0-120) HTTP == text
 fuzzy-if(Android,0-4,0-120) HTTP == text-2.html?up text-2.html?ref
 fuzzy-if(d2d,0-1,0-4) fuzzy-if(webrender,0-1,0-42) HTTP == transformed-1.html transformed-1.html?ref
 fuzzy-if(webrender,0-1,0-43) HTTP == transformed-1.html?up transformed-1.html?ref
 fuzzy-if(Android,0-5,0-20000) == uncovering-1.html uncovering-1-ref.html
 fuzzy-if(Android,0-5,0-20000) == uncovering-2.html uncovering-2-ref.html
 fuzzy-if(asyncPan&&!layersGPUAccelerated,0-149,0-4520) == less-than-scrollbar-height.html less-than-scrollbar-height-ref.html
 == huge-horizontal-overflow.html huge-horizontal-overflow-ref.html
 == huge-vertical-overflow.html huge-vertical-overflow-ref.html
-fuzzy-if(cocoaWidget&&!webrender,0-1,0-110) fuzzy-if(gtkWidget&&!nativeThemePref,0-1,0-80) fuzzy-if(winWidget&&!nativeThemePref,0-4,0-170) fuzzy-if(asyncPan&&!layersGPUAccelerated,0-102,0-6818) == iframe-scrolling-attr-1.html iframe-scrolling-attr-ref.html
-fuzzy-if(cocoaWidget&&!webrender,0-1,0-110) fuzzy-if(gtkWidget&&!nativeThemePref,0-1,0-80) fuzzy-if(winWidget&&!nativeThemePref,0-4,0-170) fuzzy-if(asyncPan&&!layersGPUAccelerated,0-140,0-6818) == iframe-scrolling-attr-2.html iframe-scrolling-attr-ref.html
+fuzzy-if(cocoaWidget&&!webrender,0-1,0-110) fuzzy-if(gtkWidget&&!nativeThemePref,0-1,0-80) fuzzy-if(winWidget&&!nativeThemePref,0-4,0-170) fuzzy-if(asyncPan&&!layersGPUAccelerated,0-102,0-6818) fuzzy-if(winWidget&&browserIsFission,0-96,0-1109) == iframe-scrolling-attr-1.html iframe-scrolling-attr-ref.html
+fuzzy-if(cocoaWidget&&!webrender,0-1,0-110) fuzzy-if(gtkWidget&&!nativeThemePref,0-1,0-80) fuzzy-if(winWidget&&!nativeThemePref,0-4,0-170) fuzzy-if(asyncPan&&!layersGPUAccelerated,0-140,0-6818) fuzzy-if(winWidget&&browserIsFission,0-96,0-1109) == iframe-scrolling-attr-2.html iframe-scrolling-attr-ref.html
 fuzzy(0-1,0-2) fuzzy-if(geckoview,0-1,0-15) fuzzy-if(cocoaWidget&&!webrender,0-1,0-13) fuzzy-if(gtkWidget&&!nativeThemePref,0-1,0-48) fuzzy-if(winWidget&&!nativeThemePref,0-4,0-108) == frame-scrolling-attr-1.html frame-scrolling-attr-ref.html
 fuzzy(0-1,0-2) fuzzy-if(asyncPan&&!layersGPUAccelerated,0-102,0-2420) fuzzy-if(geckoview,0-1,0-88) fuzzy-if(cocoaWidget&&!webrender,0-1,0-39) fuzzy-if(gtkWidget&&!nativeThemePref,0-1,0-48) fuzzy-if(winWidget&&!nativeThemePref,0-4,0-108) == frame-scrolling-attr-2.html frame-scrolling-attr-ref.html
 == move-item.html move-item-ref.html # bug 1125750
 == fractional-scroll-area.html?top=-0.4&outerBottom=100&innerBottom=200 fractional-scroll-area.html?top=0&outerBottom=100&innerBottom=200
 == fractional-scroll-area.html?top=0.4&outerBottom=100&innerBottom=200 fractional-scroll-area.html?top=0&outerBottom=100&innerBottom=200
 == fractional-scroll-area.html?top=0&outerBottom=99.6&innerBottom=200 fractional-scroll-area.html?top=0&outerBottom=100&innerBottom=200
 == fractional-scroll-area.html?top=0&outerBottom=100.4&innerBottom=200 fractional-scroll-area.html?top=0&outerBottom=100&innerBottom=200
 == fractional-scroll-area.html?top=-0.4&outerBottom=99.6&innerBottom=200 fractional-scroll-area.html?top=0&outerBottom=100&innerBottom=200

See this try push for failures.

Be sure the patch from bug 1696038 has landed (or you pull it in locally) before attempting to reproduce on try.

Comment 1

[Chris Peterson [:cpeterson]]

Here is a direct link to the reftest analyzer output for this reftest failure:

https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/eh2gnQocTcyskKMMQLQ6gQ/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

Looks like a pretty minor difference with text layout in a scrolling iframe. Tracking for Fission Future because I don't think this bug needs to block Fission MVP

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: image.png

Here is a screenshot of the differences in the reftest analyzer for posterity.