Closed
Bug 1717861
Opened 4 years ago
Closed 4 years ago
Cleanup paused & willInterrupt events in the ThreadActor
Categories
(DevTools :: Debugger, task, P3)
DevTools
Debugger
Tracking
(firefox91 fixed)
RESOLVED
FIXED
91 Branch
| Tracking | Status | |
|---|---|---|
| firefox91 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
Details
Attachments
(3 files)
The paused event payload currently emits a poppedFrames property which is only checked in tests. We can remove it.
https://searchfox.org/mozilla-central/search?path=&q=poppedFrames
| Assignee | ||
Comment 1•4 years ago
|
||
Depends on D118471
| Assignee | ||
Comment 2•4 years ago
|
||
Depends on D118607
| Assignee | ||
Comment 3•4 years ago
|
||
Depends on D118875
| Assignee | ||
Comment 4•4 years ago
|
||
Updating the summary to also cover the removal of the "error" property in the paused event, as well as the legacy "willInterrupt" event which is only used in one test and which can be replaced with another approach.
| Assignee | ||
Updated•4 years ago
|
Summary: Remove unused poppedFrames property from the ThreadActor "paused" event payload → Cleanup paused & willInterrupt events in the ThreadActor
Updated•4 years ago
|
Attachment #9229056 -
Attachment description: Bug 1717861 - [devtools] Remove willInterrupt event from thread actor → Bug 1717861 - [devtools] Remove willInterrupt event from ThreadActor
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8d78803cf328
[devtools] Remove poppedFrames from ThreadActor paused event r=ochameau,devtools-backward-compat-reviewers
https://hg.mozilla.org/integration/autoland/rev/cd70b6fca2c0
[devtools] Remove willInterrupt event from ThreadActor r=ochameau,devtools-backward-compat-reviewers
https://hg.mozilla.org/integration/autoland/rev/fbce34355e3f
[devtools] Remove error from ThreadActor paused event r=ochameau,devtools-backward-compat-reviewers
Comment 6•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8d78803cf328
https://hg.mozilla.org/mozilla-central/rev/cd70b6fca2c0
https://hg.mozilla.org/mozilla-central/rev/fbce34355e3f
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox91:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•