1717910 - Remove gmp-sanitized-cdm-exports.h from the gmp-api and hide it as an implementation detail

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, enhancement, P3)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

gmp-sanitized-cdm-exports.h doesn't need to be part of the GMP API as far as I can tell. I added it to the API as I felt it made sense at the time to expose some crypto information in the API. However, I don't believe we've ever used such info in the API, and it's just used for things like IPC, which to the best of my knowledge is an implementation detail we don't need to couple to the API.

So we could move these sanitized exports to the gmp directory, and leave them out of the API.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1717910 - Move gmp-sanitized-cdm-exports.h out of the GMP API. r?jbauman

The sanitized exports header file is used to expose the CDM headers while
undeffing symbols that clash with other parts of the build system. It doesn't
need to be exposed as part of the GMP API, as none of the symbols are used in
the GMP API.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52861272bd99
Move gmp-sanitized-cdm-exports.h out of the GMP API. r=jbauman

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/52861272bd99