1717990 - QM: Ignore NS_ERROR_ABORT in RecordFirstInitializationAttempt

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task, P2)

Description

[Jan Varga [:janv]]

If an initialization is cancelled it fails with NS_ERROR_ABORT error code. If it happens to be the first initialization attempt, the initialization is recorded as a failure in telemetry as well. We should rather ignore NS_ERROR_ABORT in RecordFirstInitializationAttempt.

We use NS_ERROR_FAILURE instead of NS_ERROR_ABORT in many places which should be fixed too.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1717990 - QM: Ignore NS_ERROR_ABORT in RecordFirstInitializationAttempt; r=#dom-storage

Depends on D118673

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1717990 - QM: Convert some NS_ERROR_FAILURE which should have been NS_ERROR_ABORT; r=#dom-storage

Depends on D118675

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 1717990 - LSNG: Convert some NS_ERROR_FAILURE which should have been NS_ERROR_ABORT; r=#dom-storage

Depends on D118676

Comment 4

[Jan Varga [:janv]]

Attachment: Bug 1717990 - SDB: Convert some NS_ERROR_FAILURE which should have been NS_ERROR_ABORT; r=#dom-storage

Depends on D118677

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8cf07efc49e7
QM: Ignore NS_ERROR_ABORT in RecordFirstInitializationAttempt; r=dom-storage-reviewers,jstutte
https://hg.mozilla.org/integration/autoland/rev/68f759c171f2
QM: Convert some NS_ERROR_FAILURE which should have been NS_ERROR_ABORT; r=dom-storage-reviewers,jstutte
https://hg.mozilla.org/integration/autoland/rev/e6f061cfca59
LSNG: Convert some NS_ERROR_FAILURE which should have been NS_ERROR_ABORT; r=dom-storage-reviewers,jstutte
https://hg.mozilla.org/integration/autoland/rev/74ceabefad3f
SDB: Convert some NS_ERROR_FAILURE which should have been NS_ERROR_ABORT; r=dom-storage-reviewers,jstutte

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/8cf07efc49e7
https://hg.mozilla.org/mozilla-central/rev/68f759c171f2
https://hg.mozilla.org/mozilla-central/rev/e6f061cfca59
https://hg.mozilla.org/mozilla-central/rev/74ceabefad3f