1718083 - Enable by default: Reload collection from packaged dump if it's newer than the existing collection

Status: RESOLVED FIXED

(Firefox :: Remote Settings Client, enhancement)

Description

[Rob Wu [:robwu]]

In bug 1717068 I'm introducing a feature to allow RemoteSettings clients to discard the local DB in favor of the packaged JSON dump if the former is out of date. This feature is used by default for a specific consumer (blocklists), but should be enabled by default (to ensure that all RemoteSettings clients have the most up-to-date data when possible).

The only reason for not making this the default behavior in bug 1717068 is to minimize the risk of regressions / backouts.

Comment 1

[Mathieu Leplatre [:leplatrem]]

Attachment: Bug 1718083 - Load dump if newer than local data r?robwu

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79f782edbda9
Load dump if newer than local data r=robwu

Comment 3

[Cristian Tuns]

Backed out for causing xpcshell failures in test_supports_filter_expressions

• Backout link
• Push with failures
• Failure Log
• Failure Log2
• Failure line: TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_targetapp_filter.js | test_supports_filter_expressions - [test_supports_filter_expressions : 55] 995 == 1

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f691cceafea6
Load dump if newer than local data r=robwu

Comment 5

[Cristian Tuns]

Backed out for causing mochitest failures in test_autocomplete_autofill_related_realms_no_dupes.html

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/mochitest/test_autocomplete_autofill_related_realms_no_dupes.html | Checking array values: Check all menuitems are displayed correctly - got 2, expected 4

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e901f3ead8eb
Load dump if newer than local data r=robwu

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e901f3ead8eb