1718226 - Do not capture crashes intercepted via Windows Error Reporting that aren't flagged as fatal

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, task)

Description

[Gabriele Svelto [:gsvelto]]

This is an attempt at fixing issues such as bug 1716120, bug 1709423 (and thus bug 1714334 too). It's a bit of a shot in the dark because WER documentation is full of holes.

I've noticed that the WER_RUNTIME_EXCEPTION_INFORMATION structure has a field called bIsFatal. I guess that this might be used to tell crashes apart from hangs and the like. Since the meaning of field is not documented anywhere I can only guess that its name is descriptive.

I'll cook up a patch to ignore crashes that have it set to false and we'll see what happens.

Comment 1

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1718226 - Only capture crash reports for fatal exceptions intercepted via WER r=KrisWright

Our Windows Error Reporting runtime module seems to be notified of all
sorts of non-fatal exceptions. Since there is no documentation clarifying
how to tell them apart from actual crashes we'll try using the bIsFatal
field in the WER_RUNTIME_EXCEPTION_INFORMATION structure for this
purpose. There is no documentation describing the contents of the field
so we can only assume that what its name implies is what we're looking
for.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/341fcf114fa1
Only capture crash reports for fatal exceptions intercepted via WER r=KrisWright

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/341fcf114fa1