Closed
Bug 1718239
Opened 3 years ago
Closed 3 years ago
Update font inspector tests to wait for the correct update event
Categories
(DevTools :: Framework, task, P3)
DevTools
Framework
Tracking
(firefox91 fixed)
RESOLVED
FIXED
91 Branch
Tracking | Status | |
---|---|---|
firefox91 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(1 file)
Font inspector tests are fragile and might retrieve an early event instead of the expected one.
Assignee | ||
Comment 1•3 years ago
|
||
Depends on D118475
Unsurprisingly, updating the inspector initialization sequence makes a few tests intermittent.
font panel tests in particular seem to get a late event intermittently, and consume it incorrectly.
This patch updates one of the font inspector events to also emit the current node handled by the font inspector.
This way tests can now clearly wait for a specific font inspector event. The event is also emitted with emitForTests now as it is not used outside of our mochitests.
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a591bc2b8192
[devtools] Wait for correct fontinspector-update event in font inspector tests r=nchevobbe
Comment 3•3 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox91:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•