1718365 - New wpt failures in /css/css-grid/grid-items/grid-item-inline-contribution-003.html

Status: NEW

(Core :: Layout: Grid, defect, P3)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Syncing wpt PR 29508 found new untriaged test failures in CI

Tests Affected

Firefox-only failures

/css/css-grid/grid-items/grid-item-inline-contribution-002.html: FAIL

New Tests That Don't Pass

/css/css-grid/grid-items/grid-item-inline-contribution-003.html: FAIL (Chrome: PASS, Safari: FAIL)

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1718352 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

grid-item-inline-contribution-002.html and grid-item-inline-contribution-003.html test exactly the Grid Sizing Algorithm step 3 https://drafts.csswg.org/css-grid-1/#algo-grid-sizing

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

We've already passed grid-item-inline-contribution-002.html. To pass grid-item-inline-contribution-003.html, we need to implement stretch alignment for grid items in the block axis when computing their intrinsic inline contribution, possibly in nsLayoutUtils::IntrinsicForAxis() near [1].

Alternatively, we could wait until bug 1789477 is fixed, and see if we can pass a block-size override containing the stretch keyword to implement the stretch alignment behavior.

[1] https://searchfox.org/mozilla-central/rev/985cbf891c4dba207968c3ad2ac2b3afb3dc1960/layout/base/nsLayoutUtils.cpp#4817-4848

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Testcase 1: Reduced from grid-item-inline-contribution-003.html

Daniel got an reduced testcase from grid-item-inline-contribution-003.html by making the grid row definite via grid-template: 100px. Nightly 142 fails this test.

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

We've fixed grid-item-inline-contribution-002.html. Edited the bug title to reflect that.