Closed
Bug 1718425
Opened 3 years ago
Closed 3 years ago
Fix setInterval syntax in chatZilla
Categories
(SeaMonkey :: Chat, defect)
SeaMonkey
Chat
Tracking
(seamonkey2.53+ fixed)
RESOLVED
FIXED
seamonkey 2.88
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.9)
Attachments
(1 file)
|
1.33 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
The setInterval calls in chatZillla use an older syntax which debuggers choke on, so let's update them.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: debugging of cZ for devs is more difficult
Testing completed (on m-c, etc.): 2.53.9
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
Attachment #9229108 -
Flags: review?(frgrahl)
Attachment #9229108 -
Flags: approval-comm-release?
Attachment #9229108 -
Flags: approval-comm-esr60?
|
||
Comment 2•3 years ago
|
||
Comment on attachment 9229108 [details] [diff] [review]
1718425-irc-setInterval-2539.patch
LGTM
Attachment #9229108 -
Flags: review?(frgrahl)
Attachment #9229108 -
Flags: review+
Attachment #9229108 -
Flags: approval-comm-release?
Attachment #9229108 -
Flags: approval-comm-release+
Attachment #9229108 -
Flags: approval-comm-esr60?
Attachment #9229108 -
Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/fda9eb463459
Fix setInterval syntax in chatZilla. r=frg
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
|
|
||
Updated•3 years ago
|
status-seamonkey2.53:
--- → affected
tracking-seamonkey2.53:
--- → ?
Whiteboard: SM2.53.9
Target Milestone: --- → seamonkey 2.88
|
|
||
Comment 4•3 years ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/89fde76d46bd8f69c0df7f622d327e640bb51c4d
Fix setInterval syntax in chatZilla. r=frg a=frg
|
|
||
Updated•3 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•