1718428 - Tidy up existing plugin code in cZ

Status: RESOLVED FIXED

(SeaMonkey :: Chat, defect)

Description

[Ian Neal]

Looking to address the following issues:

• /disable-plugin and /enable-plugin call cmdAblePlugin but they take completely separate code paths within that function so they might as well call two different functions;
• rather than checking for CMD_NO_HELP flag just set the default help as MSG_NO_HELP and remove use of that flag;
• fix missing variable declaration in cli_installPlugin function.

Comment 1

[Ian Neal]

Attachment: 1718428-irc-plugin-tidy-2539.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: for some plugins that don't have help, console becomes noisey
Testing completed (on m-c, etc.): 2.53.9
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9229109 [details] [diff] [review]
1718428-irc-plugin-tidy-2539.patch

LGTM

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b6c02014116e
Tidy up existing plugin code in cZ. r=frg

Comment 4

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/d3dad82798ef0daade1901c16fe8f421c2009d35
Tidy up existing plugin code in cZ. r=frg a=frg