1718435 - Regression - MacOS: Clear Recent History does not open when all windows are closed

Status: VERIFIED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect)

Description

[Mehmet]

Nightly 91.0a1 (2021-06-26) (64-Bit)
macOS 11.4

1.) Start Nightly on macOS
2.) Close all windows
3.) Select Clear Recent History from the Menu Bar

Actual: Clear Recent History does not open

Expected: Clear Recent History should open.

This is a regression with the switch from the separate window to the modal from bug 1712750.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1718435 - fix clear recent history dialog when there are no open windows, r?mconley

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a40a81ec0ac
fix clear recent history dialog when there are no open windows, r=mconley

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/5a40a81ec0ac

Comment 4

[:Gijs (he/him)]

Attachment: Bug 1718435 - follow-up: clean up callsite of clear recent history window that passes nsISupports-y arguments, r?mconley

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf996546dac5
follow-up: clean up callsite of clear recent history window that passes nsISupports-y arguments, r=mconley

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/cf996546dac5

Comment 7

[Oana Botisan, Desktop QA]

Managed to reproduce the issue using an older version of Nightly 2021-06-27 on macOS 10.15.
I retested everything on latest Nightly 93.0a1 and Firefox 92.0b2 using the same os. The issue is not reproducing anymore.