1718548 - Reverse checkmark status on View > Calendar > Calendar Pane > Show Calendar Pane

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: Reverse checkmark status for `Show Calendar Pane`

91.0a1 (2021-06-28) (64-bit), Win 10

STR

1. Open Calendar tab
2. View > Calendar > Calendar Pane > Show Calendar Pane
3. Observe checkmark status vs. pane visibility as you toggle the Calendar pane

Actual

Reverse checkmark status:

• Pane hidden: checkmark present
• Pane shown: checkmark absent

Expected

• Checkmark status should match pane visibility

Seems that we're just missing correct initializing somewhere, then the checkmark toggling should be alright.

Comment 1

[Lasana Murray]

Attachment: Bug 1718548 - Use setAttribute() to set calViewCalendarPane checked status. r=darktrojan

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4d93692d10f3
Use setAttribute() to set calViewCalendarPane checked status. r=darktrojan

Comment 3

[Thomas D. (:thomas8)]

Comment on attachment 9231372 [details]
Bug 1718548 - Use setAttribute() to set calViewCalendarPane checked status. r=darktrojan

[Approval Request Comment]
Regression caused by (bug #): unknown
User impact if declined: Show Calendar Pane menuitem has irritating wrong checkmark status
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): near zero (simple one-liner)

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9231372 [details]
Bug 1718548 - Use setAttribute() to set calViewCalendarPane checked status. r=darktrojan

[Triage Comment]
Approved for esr91

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 91.0.2:
https://hg.mozilla.org/releases/comm-esr91/rev/7f4f65dff841

Comment 6

[WaltS48 [:walts48]]

Verified using Thunderbird 91.0.2 on Windows 10.