1718595 - extension popup not using RGB Anti-Aliasing

Status: NEW

(Core :: Graphics, defect, P3)

Description

[Marian]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:87.0) Gecko/20100101 Firefox/87.0

Steps to reproduce:

Create a simple browser_action extension.

With DirectX 11.

Actual results:

The fonts and not using RGB Anti-Aliasing.

Expected results:

To have RGB AA.

Seams to be a regression from version from:

Good:
app_name: firefox
build_date: 2017-07-10
build_file: C:\Users\Marian.mozilla\mozregression\persist\2017-07-10--mozilla-central--firefox-56.0a1.en-US.win64.zip
build_type: nightly
build_url: https://archive.mozilla.org/pub/firefox/nightly/2017/07/2017-07-10-03-02-03-mozilla-central/firefox-56.0a1.en-US.win64.zip
changeset: a418121d46250f91728b86d9eea331029c264c30
pushlog_url: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a418121d46250f91728b86d9eea331029c264c30&tochange=09a4282d1172ac255038e7ccacfd772140b219e2
repo_name: mozilla-central
repo_url: https://hg.mozilla.org/mozilla-central

Bad:
app_name: firefox
build_date: 2017-07-11
build_file: C:\Users\Marian.mozilla\mozregression\persist\2017-07-11--mozilla-central--firefox-56.0a1.en-US.win64.zip
build_type: nightly
build_url: https://archive.mozilla.org/pub/firefox/nightly/2017/07/2017-07-11-03-02-03-mozilla-central/firefox-56.0a1.en-US.win64.zip
changeset: 0e41d07a703f19224f60b01577b2cbb5708046c9
pushlog_url: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a418121d46250f91728b86d9eea331029c264c30&tochange=0e41d07a703f19224f60b01577b2cbb5708046c9
repo_name: mozilla-central
repo_url: https://hg.mozilla.org/mozilla-central

But there is no data to check more exact the problem.

Comment 1

[Marian]

Attachment: FF.zip

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'WebExtensions::Untriaged' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 3

[Marian]

And if the button has a transition with the background, the rgb aa is disapearing.

button { background-color: #cdcdcd; transition: border-color .25s; }
button:hover { background-color: hsl(0, 0%, 95%); }

Comment 4

[Alex Cornestean]

Hello,

I’m from QA and I’m attempting to confirm the issue, however I’m not familiar with RGB Anti-Aliasing procedures.

Could you be so kind as to provide some visual reference (a screenshot or a screen recording) of the issue occurring and maybe explain in more detail what the issue is and how it should correctly behave?

Thank you !

Comment 5

[Marian]

Attachment: HmHYqR9w9x.mp4

Comment 6

[Alex Cornestean]

Thank you Marian for the screen recording !

Missed a piece of information in the STR you provided. You specified that DirectX 11 must be in use, however, on both machines I’m using I have DirectX 12 and do not have the possibility to install DirectX 11. Not exactly sure if this influences the results.

Anyway, I’ve captured a screen recording of the pop-up buttons from the FF test extension you attached.

It does not look quite so pixelated on hover as your example. Could you confirm this is the issue occurring? Thank you !

Comment 7

[Alex Cornestean]

Attachment: 2021-07-01_13h26_59.mp4

Comment 8

[Marian]

1. You have disabled the WebRender with the gfx.webrender.force-disabled to use the DirectX Compositing at about:support?
2. Disable the "Smooth edges of images and text" from Magnifier settings.

WebRender still not suporting RGB AA on any case where DX is fine.

Comment 9

[Alex Cornestean]

Set gfx.webrender.force-disabled to true in about:config and in about:support Compositing was set to use Direct3D 11 as a result (see screenshot).

I’ve disabled the "Smooth edges of images and text" from the Magnifier settings as instructed.

Tested this with both the latest Firefox Release (89.0.2/20210622155641) and Firefox Release 87.0 (87.0/20210318103112).

The screen capture below is what I got with those settings on both Firefox versions, but it seems nothing is happening beside the background color transition.

Comment 10

[Alex Cornestean]

Attachment: 2021-07-01_14h48_01.png

Comment 11

[Alex Cornestean]

Attachment: 2021-07-01_14h49_59.mp4

Comment 12

[Marian]

Attachment: FF Extension.zip

Yea. That text and button should have RGB AA.

If you put a background you will see will have it, but button with a background transition will disable AA and after is finish will get AA back.

I upload my current code.

Comment 13

[Alex Cornestean]

Thank you again for the info and support !

I managed to reproduce the issue on the latest Nightly (91.0a1/20210701101609), Beta (90.0b12/20210624190035) and Release (89.0.2/20210622155641) under Windows 10 x64.

For further details, see the attached screen recording.

Comment 14

[Alex Cornestean]

Attachment: 2021-07-01_15h39_58.mp4

Comment 15

[Luca Greco [:rpl] [:luca] [:lgreco]]

Looks like a rendering issue, the only extension-related detail in the STR is likely the fact that the extension popup does not always work exactly like a tab, despite the extension page used to reproduce the issue is exactly the same and the issue only happens in the popup window.

Moving to Core::Graphics as they may have more ideas about what may be going on here, which would be the bugzilla component this should be filed in and what would be the right next steps.

Comment 16

[Brad Werth [:bradwerth] | Out until Feb 2025]

Yes, there are known conditions where WebRender doesn't provide RGB anti-aliasing of text, which is tracked by Bug 1673225.