Closed Bug 1718700 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 29539 - [images] Fix vertical writing mode regression.

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29539 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29539
Details from upstream follow.

b'Ian Kilpatrick <ikilpatrick@chromium.org>' wrote:

[images] Fix vertical writing mode regression.

https://chromium.googlesource.com/chromium/src/+/cbae0f6d9dbf5b7145e147201df80a4836523bbe
...introduced a bug where we'd read the natural-size of the image
(in the correct writing-mode), then read the aspect-ratio.

However the aspect-ratio was in the incorrect writing-mode. The code
previous just transposed the whole data-structure, rather than just
transposing the aspect-ratio.

This fixes the issue just by transposing the aspect-ratio.

Bug: 1204409
Change-Id: Ic3425bfde9c57f8dd590ec570924403fdc4df5d8

Reviewed-on: https://chromium-review.googlesource.com/2994866
WPT-Export-Revision: 1cd2043ed77b401de2b92f2b9f955c3e70007030

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2a3699c55699 [wpt PR 29539] - [images] Fix vertical writing mode regression., a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.