1718749 - The Remote Settings Sponsored Top Sites are displayed after dismissing the Contile Sponsored Top Sites

Status: VERIFIED FIXED

(Firefox :: Top Sites, defect)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: RS Sponsored Top Sites displayed after dimissing the ones from Contile.gif

[Notes]:

• This behavior was introduced by the patch from Bug 1717847. Our concern is that the users that have both RS and Contile enabled, at some point, might dismiss the Sponsored Top Sites and after a browser restart, they will appear again. The users might feel that their decision is not respected.

[Affected versions]:

• Nightly 91.0a1;

[Affected Platforms]:

• Windows 10 x64;
• macOS 10.15.7;
• Ubuntu 20. x.0

[Prerequisites]:

• Have the latest Firefox Nightly installed.

• Have the following pref set to enable Remote Settings Sponsored Top Sites:

• browser.topsites.useRemoteSetting = true

• browser.partnerlink.useAttributionURL = true

• browser.topsites.experiment.ebay-2020-1 = true

• Have the following pref set to enable Contile:

• browser.topsites.contile.enabled = true

• Be connected to a VPN US region.

[Steps to reproduce]:

1. Open the Firefox browser with the profile from prerequisites.
2. Dismiss both Amazon and eBay Sponsored Top Site.
3. Restart the browser.
4. Observe the Top Sites.

[Expected result]:

• No Sponsored Top Site is displayed.

[Actual result]:

• The previously dismissed Sponsored Top Sites are displayed.

[Additional Notes]:

• Attached a screen recording of the issue.

Comment 1

[Nan Jiang [:nanj]]

Attachment: Bug 1718749 - Filter blocked sponsored top sites from RemoteSettings when Contile is enabled r=dao

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0273f4c5ba4d
Filter blocked sponsored top sites from RemoteSettings when Contile is enabled r=dao

Comment 3

[Nan Jiang [:nanj]]

[Tracking Requested - why for this release]: This is needed for the upcoming Contile rollout in Firefox 90.

Comment 4

[Nan Jiang [:nanj]]

Comment on attachment 9229570 [details]
Bug 1718749 - Filter blocked sponsored top sites from RemoteSettings when Contile is enabled r=dao

Beta/Release Uplift Approval Request

• User impact if declined: Certain users might see the dismissed sponsored top sites on the newtab page.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please see comment 1 of bug 1718749.
• List of other uplifts needed: Bug 1717847
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a minor change to bug 1717847
• String changes made/needed: None

Comment 5

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9229570 [details]
Bug 1718749 - Filter blocked sponsored top sites from RemoteSettings when Contile is enabled r=dao

approved for 90 rc1

Comment 6

[Julien Cristau [:jcristau] (back April 22)]

https://hg.mozilla.org/releases/mozilla-release/rev/2e53fc86c0a5

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0273f4c5ba4d

Comment 8

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on Firefox RC 90 build 1 and the latest Nightly 91.0a1 build (Build ID: 20210706094632) on Windows 10 x64, macOS 10.15.7, Ubuntu 20 x64.

• The Sponsored Top Sites are no longer displayed after they are dismissed and the browser is restarted.