1718781 - When href is missing from a preload link it ignores imagesrcset

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[derekmj74]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:90.0) Gecko/20100101 Firefox/90.0

Steps to reproduce:

I've shortened the image names but apart from that I used this HTML:

<link rel="preload" imagesrcset="small.jpg 100w, medium.jpg 500w, large.jpg 1000w" imagesizes="100vw" as="image">

Actual results:

The image did not preload.

Expected results:

I think this line "One or both of the href or imagesrcset attributes must be present." from https://html.spec.whatwg.org/multipage/semantics.html#the-link-element means the href can be absent and the preloading will still work. I tested in Chrome and Edge and it works there.

In Firefox I have to use an empty href i.e. href="", which the spec disallows if I'm reading it right.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Core & HTML' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

This might be a rather simple bug to fix.

Comment 3

[Sean Feng [:sefeng211]]

Yeah..perhaps Document::ResolvePreloadImage needs to be tweaked? Still an S3 I believe

Comment 5

[Leo Tenenbaum [:ltenenbaum]]

Attachment: WIP: Bug 1718781 - Allow image preload with imagesrcset but no href. r=#dom-core

Comment 6

[Akeldama]

Attachment: Bug 1718781 - Allow image preload with imagesrcset but no href r=#dom-core

Comment 7

[Akeldama]

I noticed D285549 is still a WIP. I've been working on this too, and my patch also covers the speculative parser path (nsHtml5TreeBuilderCppSupplement.h), which handles preloads during initial HTML parsing. Happy to collaborate, or have both reviewed together.

https://phabricator.services.mozilla.com/D285588

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/04df504fed67
https://hg.mozilla.org/integration/autoland/rev/9601a9bbf362
Allow image preload with imagesrcset but no href r=edgar

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/58482 for changes under testing/web-platform/tests

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/9601a9bbf362

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot