1718815 - Move some methods/nested classes of `EditorBase` to `HTMLEditor`

Status: RESOLVED FIXED

(Core :: DOM: Editor, task, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

Some methods and nested classes of EditorBase are not used by TextEditor. So, we can move them to HTMLEditor.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

Attachment: Bug 1718815 - part 1: Move `EditorBase::AddTransactionListener()` and `EditorBase::RemoveTransactionListener()` to `HTMLEditor` r=m_kato!

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

Attachment: Bug 1718815 - part 2: Move `EditorBase::AutoSelectionRestorer` and `EditorBase` methods called only by it to `HTMLEditor` r=m_kato!

Unfortunately, marking its constructor and destructor as MOZ_CAN_RUN_SCRIPT,
Maybe<AutoSelectionRestorer>::reset() and
Maybe<AutoSelectionRestorer>::emplace() cause bustage. Therefore, this patch
just mark them as MOZ_CAN_RUN_SCRIPT_BOUNDARY.

Note that EditorBase::SavedSelectionRef() cannot be moved to HTMLEditor
because mEditActionData is a private member of EditorBase.

Depends on D119001

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

Attachment: Bug 1718815 - part 3: Move `EditorBase::AutoTransactionBatch` to `HTMLEditor` r=m_kato!

I guess that this class is replaced with AutoPlaceholderBatch, and both of
them are followed by its instances. However, I don't want to change the
behavior in this bug. Therefore, this patch just moves it into HTMLEditor.

Depends on D119002

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

Attachment: Bug 1718815 - part 4: Move `EditorBase::AppendNodeToSelectionAsRange()` and `EditorBase::ClearSelection()` to `HTMLEditor` r=m_kato!

Depends on D119003

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f32e7018fa64
part 1: Move `EditorBase::AddTransactionListener()` and `EditorBase::RemoveTransactionListener()` to `HTMLEditor` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/71b725af1aba
part 2: Move `EditorBase::AutoSelectionRestorer` and `EditorBase` methods called only by it to `HTMLEditor` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/c118124ce70e
part 3: Move `EditorBase::AutoTransactionBatch` to `HTMLEditor` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/c471c8c0a12a
part 4: Move `EditorBase::AppendNodeToSelectionAsRange()` and `EditorBase::ClearSelection()` to `HTMLEditor` r=m_kato

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/f32e7018fa64
https://hg.mozilla.org/mozilla-central/rev/71b725af1aba
https://hg.mozilla.org/mozilla-central/rev/c118124ce70e
https://hg.mozilla.org/mozilla-central/rev/c471c8c0a12a