1718876 - Missing "Sync Now" label in synced tabs sidebar filter context menu

Status: NEW

(Firefox :: Sync, defect, P3)

Description

[Shane Hughes [:aminomancer]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

• Open synced tabs sidebar.
• Right click the textbox.

Actual results:

• The "Sync Now" menuitem is missing a label because its lazy l10n ID is never converted into a real data-l10n-id attribute by this function, which only looks in the regular context menu, not the filter context menu.

Expected results:

• The relevant part of this function should be changed to this:

["SyncedTabsSidebarContext", "SyncedTabsSidebarTabsFilterContext"].forEach((id) =>
    window.top.document
        .getElementById(id)
        .querySelectorAll("[data-lazy-l10n-id]")
        .forEach((el) => {
            el.setAttribute("data-l10n-id", el.getAttribute("data-lazy-l10n-id"));
            el.removeAttribute("data-lazy-l10n-id");
        })
);

Either that, or the attribute should just be changed to data-l10n-id and avoid all this. I assume there's some good reason that wasn't done in the first place though.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Tabbed Browser' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Hani Yacoub, Desktop QA]

Managed to reproduce this issue on Windows 10 x64.
On macOS and on Ubuntu after you right click on synced tabs sidebar a context menu is opened with options to: Open All in Tabs, Manage Devices and Sync Now

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:bdk, could you have a look please?

For more information, please visit BugBot documentation.

Comment 4

[Ben Dean-Kawamura [:bdk]]

If we're planning on removing the Sync Now item, should we just close this one WONTFIX? It seems simpler to remove the item than to fix the label issue.

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Yeah, once bug 1828744 is done this can probably be "WONTFIX" - but not really before. I agree this motivates us to do that other bug though.