1718919 - [wpt-sync] Sync PR 29565 - Support BigInt/Uint64Array in crypto.getRandomValues

Status: RESOLVED FIXED

(Core :: DOM: Security, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 29565 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29565
Details from upstream follow.

b'Timothy Gu <[e-mail]>' wrote:

Support BigInt/Uint64Array in crypto.getRandomValues

The check for "integer arrays" is to prevent people from using
getRandomValues with floating-point arrays, which doesn't work as people
might expect. However, the check was not updated when Chrome gained
support for BigInt64Array and BigUint64Array, which do work as expected.
This allows code fragments such as

 const b = new BigInt64Array(10);
 crypto.getRandomValues(b);

See https://github.com/w3c/webcrypto/issues/255 for the spec issue.

Bug: 1225765
Change-Id: I338ecc5594492e6f329580f4e8f04d367f866361
Reviewed-on: https://chromium-review.googlesource.com/3002049
WPT-Export-Revision: 7080cff46b3d344f66c0aca0fea60f0d2c2ce760

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=29709e3f3b46b3a585a4f0638307d4a1168b9439

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 6 subtests

Status Summary

Firefox

OK : 2
FAIL: 12

Chrome

OK : 2
FAIL: 12

Safari

OK : 2
FAIL: 12

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/WebCryptoAPI/getRandomValues-bigint.tentative.any.worker.html
Integer array: BigInt64Array: FAIL (Chrome: FAIL, Safari: FAIL)
Large length: BigInt64Array: FAIL (Chrome: FAIL, Safari: FAIL)
Null arrays: BigInt64Array: FAIL (Chrome: FAIL, Safari: FAIL)
Integer array: BigUint64Array: FAIL (Chrome: FAIL, Safari: FAIL)
Large length: BigUint64Array: FAIL (Chrome: FAIL, Safari: FAIL)
Null arrays: BigUint64Array: FAIL (Chrome: FAIL, Safari: FAIL)
/WebCryptoAPI/getRandomValues-bigint.tentative.any.html
Integer array: BigInt64Array: FAIL (Chrome: FAIL, Safari: FAIL)
Large length: BigInt64Array: FAIL (Chrome: FAIL, Safari: FAIL)
Null arrays: BigInt64Array: FAIL (Chrome: FAIL, Safari: FAIL)
Integer array: BigUint64Array: FAIL (Chrome: FAIL, Safari: FAIL)
Large length: BigUint64Array: FAIL (Chrome: FAIL, Safari: FAIL)
Null arrays: BigUint64Array: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Timothy Gu [:TimothyGu]]

This will be automatically fixed as part of bug 1718932.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1c491b1f6d0
[wpt PR 29565] - Update wpt metadata, a=testonly

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18dccd9c4563
[wpt PR 29565] - Update wpt metadata, a=testonly

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/18dccd9c4563