1719020 - Format Toolbar forgets its hidden status when switching to other view modes

Status: RESOLVED FIXED

(SeaMonkey :: Composer, defect)

Description

[cyuikoru]

Attachment: video demonstrating the bug

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0 SeaMonkey/2.53.8

Steps to reproduce:

-open a new Composer window
-View→Show/Hide→Format Toolbar
-the toolbar is hidden
-View→any of these:Normal Edit Mode,HTML Tags,Preview

Actual results:

the toolbar shows up after switching

Expected results:

the toolbar keeps hidden

Comment 1

[cyuikoru]

-if the video is shown as corrupted in the browser,download it and play in something like VLC or MPC-HC since i used CamStudio codec while recording
-the bug does not show up after giving the page a title name

Comment 2

[cyuikoru]

-the bug does not show up after giving the page a title name
actually during recording session i did that and the bug somehow did not appear so i assumed that was a thing
after recording i repeated the process with page given title name i could not make that happen again so this note is now invalid

Comment 3

[Frank-Rainer Grahl (:frg)]

I can reproduce with a new composer window and think this should not happen.

Comment 4

[cyuikoru]

seems like this bug affects all states of Composer windows,not just when it is blank new

Comment 5

[Rainer Bielefeld]

REPRODUCIBLE with installation of unofficial (by wg9s) De SeaMonkey 2.53.9 beta 1 Mozilla/5.0 (NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0 Build 20210628210003 (Newly created User Profile, Default Classic Theme) on German WIN7 64bit

I compared with 2.40, there we had a different problem:

1. Open new composer Window
2. Hide Format toolbar by removing check mark in Menu ˋView → Show/Hideˊ
   » Format Toolbar vanishes
3. Menu ˋView → HTML Sourceˊ
   » Expected: Format Toolbar stays hidden
   Actual: Format Toolbar visible 😥
4. Menu ˋView → Show/Hideˊ
   » Expected: Format Toolbar item with checkmark because it's visible
   Actual: Checkmark missing although Format Toolbar is missing. Checkmark and reality concerning visibility of F. T. do not match 😥

Maybe the changes that eliminated the 2.40 problem caused the current one?

Also see Bug 185829 - View > Show/Hide > Format Toolbar setting doesn't stick when opening new composer window

Comment 6

[cyuikoru]

update:now i found the reason why the bug seemed to "disappear" during my recording
if i go to any of the mentioned view modes,hide the toolbar and then move to HTML Source view,when you go back to any modes the toolbar stay hidden
if you never go to HTML Source view the bug will appears

Comment 7

[cyuikoru]

update:now i found the reason why the bug seemed to "disappear" during my recording
if i go to any of the mentioned view modes,hide the toolbar and then move to HTML Source view,when you go back to any modes the toolbar stay hidden
if you never go to HTML Source view the bug will appears

so to temporarily keep the toolbar hidden you have to hide the toolbar,switch to HTML Source view immediately and move to the view you want

Comment 8

[cyuikoru]

so to temporarily keep the toolbar hidden you have to hide the toolbar,switch to HTML Source view immediately and move to the view you want

that is redundant
also the check is properly marked when switching views this time

Comment 9

[Nuno Silva [:njsg]]

Attachment: 1719020-composer-format-toolbar.patch

In editor.js, gFormatToolbarHidden is used to keep the user-set visibility (the "hidden" attribute) for this toolbar when switching to the Source view, but the stored value is always restored when moving to any other view (even if not coming from the Source view).

If the toolbar was visible when you last entered the Source view, or if you have not used that view yet, the stored value will be "false". This can then be reproduced by hiding the toolbar and switching to any view that is not Source view: the toolbar will be restored.

If you have visited the Source view with this toolbar hidden, the stored value is now "true". If you unhide the toolbar and switch to another view that is not Source view, the toolbar will be set to hidden.

Comment 10

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9264426 [details] [diff] [review]
1719020-composer-format-toolbar.patch

lgtm

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/47b9ad2f5098
Restore Composer Format Toolbar only when leaving source mode. r=frg

Comment 12

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/5812c1e3926533a0923ba9bc6500eea0783f8dbb
Restore Composer Format Toolbar only when leaving source mode. r=frg a=frg