1719177 - [Dark theme] Network calendars not readable in calendar creation dialog

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Richard Marti (:Paenglab)]

With dark TB theme in calendar creation dialog the network calendars aren't readable because of black text on dark background.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1719177-calendar-creation-dark.patch

The richlistitem had a hard coded colour. Removed it and also hide the outline because clicking on the richlistitem lets flashing the outline.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9229759 [details] [diff] [review]
1719177-calendar-creation-dark.patch

Review of attachment 9229759 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Please, update the commit message with:
"Fix text color in calendar creation dialog for dark theme"

::: calendar/base/themes/common/calendar-creation.css
@@ +68,5 @@
>  #network-calendar-list > richlistitem {
>    -moz-box-align: center;
>    background-color: transparent;
>    border: 1px transparent solid;
> +  outline: none !important;

Let's not remove the outline in this patch as it creates a weird state in which the richlistitem is focused but the focus ring is not visible.
We should improve the focus ring in a follow up patch.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1719177-calendar-creation-dark.patch

Removing only the colour.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cd390b180ae8
Make the network calendars in calendar creation dialog readable with dark theme. r=aleca