Closed Bug 1719177 Opened 3 years ago Closed 3 years ago

[Dark theme] Network calendars not readable in calendar creation dialog

Categories

(Calendar :: General, defect)

defect

Tracking

(thunderbird_esr78 wontfix)

RESOLVED FIXED
91 Branch
Tracking Status
thunderbird_esr78 --- wontfix

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

With dark TB theme in calendar creation dialog the network calendars aren't readable because of black text on dark background.

The richlistitem had a hard coded colour. Removed it and also hide the outline because clicking on the richlistitem lets flashing the outline.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9229759 - Flags: review?(alessandro)
Comment on attachment 9229759 [details] [diff] [review]
1719177-calendar-creation-dark.patch

Review of attachment 9229759 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Please, update the commit message with:
"Fix text color in calendar creation dialog for dark theme"

::: calendar/base/themes/common/calendar-creation.css
@@ +68,5 @@
>  #network-calendar-list > richlistitem {
>    -moz-box-align: center;
>    background-color: transparent;
>    border: 1px transparent solid;
> +  outline: none !important;

Let's not remove the outline in this patch as it creates a weird state in which the richlistitem is focused but the focus ring is not visible.
We should improve the focus ring in a follow up patch.
Attachment #9229759 - Flags: review?(alessandro) → review+

Removing only the colour.

Attachment #9229759 - Attachment is obsolete: true
Attachment #9229774 - Flags: review+
Target Milestone: --- → 91 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/cd390b180ae8
Make the network calendars in calendar creation dialog readable with dark theme. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: