1719235 - Remove mozmill from calendar tests

Status: RESOLVED FIXED

(Calendar :: General, task)

Description

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

I'm going to try to eradicate mozmill from the calendar tests.

Comment 1

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

Attachment: Bug 1719235 - Reorganise calendar test module files. r=lasana

Just tidying up some mess before we get started.

Comment 2

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

Attachment: Bug 1719235 - Stop using mozmill controllers in CalendarUtils event dialog functions. r=lasana

Depends on D119143

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1bbda040be5b
Reorganise calendar test module files. r=lasana

Comment 4

[Martin Schröder [:mschroeder]]

Just the first part landed, therefore re-opening.

Comment 5

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

Yeah, oops, forgot to set this. There'll be more patches, so doing it now while I remember.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/87471ad191de
Stop using mozmill controllers in CalendarUtils event dialog functions. r=lasana

Comment 7

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

Attachment: Bug 1719235 - Convert some more CalendarUtils functions from Mozmill. r=lasana

Comment 8

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

Attachment: Bug 1719235 - Use `window` and `document` where appropriate in calendar tests. r=lasana

Depends on D120430

Comment 9

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

Attachment: Bug 1719235 - Stop using controller.sleep and controller.waitFor in calendar tests. r=lasana

Depends on D120431

Comment 10

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

Attachment: Bug 1719235 - Stop using controller.click in calendar tests. r=lasana

Depends on D120432

Comment 11

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

Attachment: Bug 1719235 - Stop using controller in createCalendar/deleteCalendars. r=lasana

Depends on D120433

Comment 12

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

Attachment: Bug 1719235 - Stop using Mozmill controllers in calendar tests. r=lasana

Depends on D120434

Comment 13

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

Attachment: Bug 1719235 - Tidy up a few loose ends. r=lasana

Depends on D120435

Comment 14

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

Attachment: Bug 1719235 - Move goToDate and goToToday to CalendarTestUtils. r=lasana

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/24fca97b3207
Convert some more CalendarUtils functions from Mozmill. r=lasana
https://hg.mozilla.org/comm-central/rev/b453147567da
Use `window` and `document` where appropriate in calendar tests. r=lasana
https://hg.mozilla.org/comm-central/rev/484b4b897fc1
Stop using controller.sleep and controller.waitFor in calendar tests. r=lasana
https://hg.mozilla.org/comm-central/rev/53f526094039
Stop using controller.click in calendar tests. r=lasana
https://hg.mozilla.org/comm-central/rev/5f2f40f9b8c9
Stop using controller in createCalendar/deleteCalendars. r=lasana
https://hg.mozilla.org/comm-central/rev/4f198dd7ce12
Stop using Mozmill controllers in calendar tests. r=lasana
https://hg.mozilla.org/comm-central/rev/e1153f693eff
Tidy up a few loose ends. r=lasana
https://hg.mozilla.org/comm-central/rev/69d7ac0f5c43
Move goToDate and goToToday to CalendarTestUtils. r=lasana

Comment 16

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

Nearly there. I've got it out of the calendar test modules, now I just need to figure out where FolderDisplayHelpers is still needed and why, and remove some uses of WindowDisplayHelpers that are still hanging around.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cffe48e47d76
Clean up a created calendar after use. rs=bustage-fix

Comment 18

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

Attachment: Bug 1719235 - Use CalendarTestUtils to create and remove calendars in tests. r=lasana

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4e7e2517849a
Use CalendarTestUtils to create and remove calendars in tests. r=lasana

Comment 20

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

Woohoo!