Closed
Bug 1719240
Opened 3 years ago
Closed 3 years ago
Better hide the profiler mutex inside the locking class
Categories
(Core :: Gecko Profiler, task, P3)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
92 Branch
| Tracking | Status | |
|---|---|---|
| firefox92 | --- | fixed |
People
(Reporter: mozbugz, Assigned: mozbugz)
References
Details
Attachments
(2 files)
For better safety, and a bit less repetition.
Also, the state-change mutex shouldn't use PSMutex.
|
Assignee | |
Comment 1•3 years ago
|
||
PSMutex/Autolock are reserved for the main profiler mutex (which will change in the next patch.)
|
|
Assignee | |
Comment 2•3 years ago
|
||
This prevents unwanted direct access to the mutex, and removes duplicated code.
And make the Base Profiler mutex&lock consistent.
Depends on D119146
Pushed by gsquelart@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1986b5e138a6 Use BaseProfilerMutex and Lock for state-change APIs - r=canaltinova https://hg.mozilla.org/integration/autoland/rev/cd35ed685cff Rework PSMutex into PSAutoLock - r=canaltinova
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1986b5e138a6
https://hg.mozilla.org/mozilla-central/rev/cd35ed685cff
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox92:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•