1719352 - CSS files not checked in in browser/components/newtab

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Emily McMinn :emcminn]

I've found some changes to activity-stream-linux.css, activity-stream-mac.css &activity-stream-windows.css inside browser/components/newtab that weren't bundled from the SCSS. (Looks like edits were made directly to the css files.)

I'm pretty sure it's a result of https://bugzilla.mozilla.org/show_bug.cgi?id=1712222; Scott or Amy, would you mind checking it out?

Docs here just in case :)

EDIT: You can see the specific changes on this diff: https://phabricator.services.mozilla.com/D118630?id=456214 ; they got picked up when I rebased against m-c this morning.

Comment 1

[Scott [:thecount] Downe]

I remember there being some headaches with landing a set of patches that Amy was dealing with, maybe that caused some of the removals to the built css files.

Comment 2

[Scott [:thecount] Downe]

Attachment: Bug 1719352 - Some newtab css changes to generated css files.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e42adcd4838
Some newtab css changes to generated css files. r=amy,emcminn

Comment 4

[Atila Butkovits]

Backed out for causing failures on browser_parsable_css.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/e806428569824e8b75664663ad5289ad5c6a3c31

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=N6BlzjJaTGKhpWkc9NU29A.0&revision=2e42adcd4838ed7b33a4725e7f4eaf9bd5fa3520&searchStr=linux%2C18.04%2Cx64%2Copt%2Cmochitests%2Ctest-linux1804-64%2Fopt-mochitest-browser-chrome-e10s%2Cbc3

Failure log: https://treeherder.mozilla.org/logviewer?job_id=344507507&repo=autoland&lineNumber=2481

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d54ed3c681cc
Some newtab css changes to generated css files. r=emcminn,amy

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/d54ed3c681cc

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1712222