1719364 - Please add `www.ebay.fr` to Contile ADM settings

Status: RESOLVED FIXED

(Cloud Services :: Operations: Top Sites, task)

Description

[JR Conlin [:jrconlin,:jconlin]]

diff --git a/projects/topsites/k8s/charts/contile/values.yaml b/projects/topsites/k8s/charts/contile/values.yaml
index 9b3de5bbd..8d5cfc139 100644
--- a/projects/topsites/k8s/charts/contile/values.yaml
+++ b/projects/topsites/k8s/charts/contile/values.yaml
@@ -72,6 +72,7 @@ contileAdmSettings:
     - www.ebay.com.au
     - www.ebay.ca
     - www.ebay.de
+    - www.ebay.fr
     click_hosts: []
     impression_hosts: []
     include_regions: []

Comment 1

[Aaron Stults]

(In reply to JR Conlin [:jrconlin,:jconlin] from comment #0)

diff --git a/projects/topsites/k8s/charts/contile/values.yaml b/projects/topsites/k8s/charts/contile/values.yaml
index 9b3de5bbd..8d5cfc139 100644
--- a/projects/topsites/k8s/charts/contile/values.yaml
+++ b/projects/topsites/k8s/charts/contile/values.yaml
@@ -72,6 +72,7 @@ contileAdmSettings:
     - www.ebay.com.au
     - www.ebay.ca
     - www.ebay.de
+    - www.ebay.fr
     click_hosts: []
     impression_hosts: []
     include_regions: []

Hi JR, since @jbuck is out until next week I can take this. Did you already have a branch in this repo or should I just go ahead and make this update?

Comment 2

[JR Conlin [:jrconlin,:jconlin]]

Hi JR, since @jbuck is out until next week I can take this. Did you already have a branch in this repo or should I just go ahead and make this update?

Hi Aaron! Yep, you can take it if you like. Hold off for a bit, though, since there may be additional items incoming.

I don't have a proper PR open, because I don't have submit access to the repo. (I could create one from a fork if that works for y'all. Let me know what's easiest for you.)

Comment 3

[Aaron Stults]

No problem, I created a branch and started a PR here: https://github.com/mozilla-services/cloudops-infra/pull/3225

Let me know if there is more to add, or whenever you'd like this merged/pushed to stage!

Comment 4

[JR Conlin [:jrconlin,:jconlin]]

Since there's a bunch of new entries, I forked the cloudops-infra repo and submitted a new PR:
https://github.com/mozilla-services/cloudops-infra/pull/3227

Comment 5

[Aaron Stults]

(In reply to JR Conlin [:jrconlin,:jconlin] from comment #4)

Since there's a bunch of new entries, I forked the cloudops-infra repo and submitted a new PR:
https://github.com/mozilla-services/cloudops-infra/pull/3227

Thanks! Is this ok to be merged and pushed to stage at this point? Or is there any other reviews/approvals needed?

Comment 6

[JR Conlin [:jrconlin,:jconlin]]

Yes, we should be good to go to get this to stage to test.

Thanks!

Comment 7

[Aaron Stults]

This has been merged and rolled out to stage