1719402 - Store CanLazilyParse condition into Stencil and Stencil XDR

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Tooru Fujisawa [:arai]]

Currently we use CompilationInput.options fields in CompilationStencil::instantiateStencilAfterPreparation to check if the compilation is full-parse or not.
but given that Stencil allows separating compilation step and instantiation step, with or without XDR, requireing the consumer to pass the same CompileOptions for both steps seems to be pitfall.

we should store the CanLazilyParse(input.options) information into CompilationStencil instead, and use the information in instantiation step.

Comment 1

[Tooru Fujisawa [:arai]]

of course we could still receive the CompileOptions, and check if the field matches, and throws error on mismatch.

Comment 2

[Tooru Fujisawa [:arai]]

After we split CompileOptions into 2 parts, one for compile-to-stencil, and one for instantiation, we can omit CanLazilyParse part from instantiation.

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1719402 - Part 1: Reorder CompilationStencil fields and ExtensibleCompilationStencil fields to match. r?nbp!

Depends on D119292

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1719402 - Part 2: Add CompilationStencil.canLazilyParse field and use it during instantiation. r?nbp!

Depends on D119293

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3807e3a44d79
Part 1: Reorder CompilationStencil fields and ExtensibleCompilationStencil fields to match. r=nbp
https://hg.mozilla.org/integration/autoland/rev/622a9c1787a2
Part 2: Add CompilationStencil.canLazilyParse field and use it during instantiation. r=nbp

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3807e3a44d79
https://hg.mozilla.org/mozilla-central/rev/622a9c1787a2