Closed Bug 1719407 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 29585 - Revert "Upstream JS Self-Profiling API WPTs"

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox92 fixed)

Status:
RESOLVED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox92 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29585 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29585
Details from upstream follow.

b'Maggie Cai <mxcai@chromium.org>' wrote:

Revert "Upstream JS Self-Profiling API WPTs"

This reverts commit 1fcdcf2926feea61cf58e3439ab1b44cdaf76015.

Reason for revert: This CL is likely the culprit for test failure for external/wpt/js-self-profiling/function-names.https.html in Mac bots. Some failed bots:
https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.12%20Tests/44917/overview
https://ci.chromium.org/ui/p/chromium/builders/ci/Mac11%20Tests/1836/overview
https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.13%20Tests/39508/overview
https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.14%20Tests/16882/overview

Original change's description:

Upstream JS Self-Profiling API WPTs

As the sampling requirement is enforced by a SHOULD clause in the spec,
we can normatively test that a sample occurs within one sample interval.
Fall back to this approach until manual sample collection is available,
enabling us to upstream the WPTs.

Bug: 956688
Change-Id: I979eb079425907a39630aca456c7b46a96403751
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3009982
Reviewed-by: Nicolás Peña Moreno \<npm@chromium.org>
Commit-Queue: Andrew Comminos \<acomminos@fb.com>
Cr-Commit-Position: refs/heads/master@{#898969}

Bug: 956688
Change-Id: Ie1b33c3ccd0454eafda9fff56f225b1cf21075b3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Reviewed-on: https://chromium-review.googlesource.com/3010476
WPT-Export-Revision: 3a7371cb6a9da28f8bd25253dab882c77de2f7fc

PR 29585 applied with additional changes from upstream: 1395825b40ef5ce8de8bde449ce9b1fa624804e8
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fee9007fd3e1 [wpt PR 29585] - Revert "Upstream JS Self-Profiling API WPTs", a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/22314c823c21 [wpt PR 29585] - Revert "Upstream JS Self-Profiling API WPTs", a=testonly

https://hg.mozilla.org/mozilla-central/rev/22314c823c21

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox92: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.