1719410 - Firefox spellcheck in Facebook error

Status: RESOLVED WORKSFORME

(Core :: Spelling checker, defect, P3)

Description

[Yani]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

Type afdasdf asdf asdf into a Facebook post

NOTE this is NOT happening in Bugzilla and other forums. It is likely Facebook specific.

Issues started 1-2 weeks ago, I think.

91.0a1 (2021-07-06) (64-bit)
Windows 10

Actual results:

Spell check fails to maintain the red line.
It can be re-triggered by putting the cursor in the misspelled word,
however when the word is replaced all text in the misspelled work right of the cursor is added after the replaced word.

Expected results:

Misspelled words are underlined

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Spelling checker' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Yani]

Looks fixed in the last patch. (?)

Comment 3

[Yani]

And now it is back again, clearly still not resolved.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

I tried and failed to reproduce.

I wonder if https://bugzilla.mozilla.org/show_bug.cgi?id=1687263 could have caused this.
Could you perhaps try https://mozilla.github.io/mozregression/ to find when the change happened

Comment 5

[Bogdan Maris, Desktop Test Engineering]

Attachment: Gif showing the possible issue

I also could not reproduce this in a Facebook post, the spell check red line is maintained on all words.

I did see something inside the comments input field that I could also reproduce on old Nightly builds from 2018 as well but I am not sure if this is the same thing that Yani is reporting here.
STR:

1. Open a comment input field from facebook
2. Type 'asdf asdf asdf asdf asdf'
3. Press space (to add a space), backspace (to delete the added space) and space again (to add a space)

Actual result:

• Only the last two words have the spellcheck red line.

Note:

• All the red lines appear again if clicking to add a post, dismiss the post and then refocus the unsubmitted comment.

Comment 6

[Mirko Brodesser (:mbrodesser-Igalia)]

(In reply to Bogdan Maris [:bogdan_maris], Release Desktop QA from comment #5)

Created attachment 9239652 [details]
Gif showing the possible issue

I also could not reproduce this in a Facebook post, the spell check red line is maintained on all words.

I did see something inside the comments input field that I could also reproduce on old Nightly builds from 2018 as well

That's important to know, thanks.

but I am not sure if this is the same thing that Yani is reporting here.

STR:

1. Open a comment input field from facebook
2. Type 'asdf asdf asdf asdf asdf'
3. Press space (to add a space), backspace (to delete the added space) and space again (to add a space)

Actual result:

• Only the last two words have the spellcheck red line.

Note:

• All the red lines appear again if clicking to add a post, dismiss the post and then refocus the unsubmitted comment.

Interesting finding. Couldn't reproduce that with a smaller example, i.e. typing into data:text/html,<textarea rows=20 cols=50>.
Bogdan: can you reproduce the issue when opening data:text/html,<textarea rows=20 cols=50> instead of Facebook? On which operating system did you try the above?

Comment 7

[Bogdan Maris, Desktop Test Engineering]

Not reproducing on data:text/html,<textarea rows=20 cols=50>, I was using Windows 10 64bit but I also could reproduce on Ubuntu 18.04 and MacOS 11.5 on facebook.

Comment 8

[Yani]

Seems resolved. Could have been Facebook injecting something that was screwing things up. It was either only or mostly in Facebook where it occurred.

Comment 9

[Yani]

I'm seeing this happening again today. It's definitely intermittent. You can trigger the spell check back on by turning it off and on. But it "switches off" again for no reason I can see here.

I only see the issue on Facebook. Perhaps only in comments and not post starters?

Comment 10

[Kagami Rosylight [:saschanaz] (they/them)]

This specifically doesn't happen anymore. Feel free to comment if it still happens.