1719492 - Migrate screenshot icons into the browser/component/screenshots directory

Status: RESOLVED FIXED

(Firefox :: Screenshots, enhancement, P2)

Description

[Emma Malysz]

All of screenshots icons in the extension (https://searchfox.org/mozilla-central/source/browser/extensions/screenshots/icons) should be moved to the new screenshots directory.

Here would be an example on how to migrate cancel.svg:

1. hg mv browser/extensions/screenshots/icons/cancel.svg browser/components/screenshots/content/cancel.svg.
2. Within the screenshot's jar.mn file, we would have to reference that file.
3. We would then have to remove the image's references from browser/extensions/screenshots/manifest.json and browser/extensions/screenshots/moz.build.
4. Update the references for the specific svg to use the new path. If we're taking cancel.svg as an example, what would be the new src we use here https://searchfox.org/mozilla-central/source/browser/extensions/screenshots/selector/ui.js#414-416? This may be a good hint: https://searchfox.org/mozilla-central/rev/9c9f2f85d00aef1943cb521ac95c72bae932ebc5/browser/components/aboutlogins/content/aboutLogins.html#275.
5. Verify that the icon looks correct in the screenshots UI
6. Repeat for all svgs

Comment 1

[Kajal Sah]

Attachment: Bug 1719492 Migrates screenshot icons into the browser/component/screenshots directory.r?emalysz,sfoster

Comment 2

[Kajal Sah]

Attachment: Bug 1719492 - Migrates screenshot icons into the browser/component/screenshots directory. r?emalysz,sfoster

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b12a0c04a68b
Migrates screenshot icons into the browser/component/screenshots directory. r=emalysz

Comment 4

[Cristian Brindusan [:cbrindusan]]

Backed out changeset b12a0c04a68b (Bug 1719492) for causing bc failures in browser_all_files_referenced.js.
https://hg.mozilla.org/integration/autoland/rev/7244d9960075c25333b7c650ad4cafa3f3f71be1

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=b12a0c04a68bda60aae6b05905501b22cb8e3d29&selectedTaskRun=LdMlYuy9SFC_ERoQ_oqMmQ.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=345761115&repo=autoland&lineNumber=3630

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d53ab517f06
Migrates screenshot icons into the browser/component/screenshots directory. r=emalysz

Comment 6

[Atila Butkovits]

Backed out for causing bc failures at browser_all_files_referenced.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/5bd8ce81a52f4865c4c9cde731cec25937baf095

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=7d53ab517f0688d6a7e1f4358d9fb149b557d380&searchStr=bc&selectedTaskRun=ESb24gT3T76dz9c7ZfIyvQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=345943947&repo=autoland&lineNumber=2849

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a82a8b89077
Migrates screenshot icons into the browser/component/screenshots directory. r=emalysz

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1a82a8b89077