Closed Bug 1719591 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29604 - [LayoutNG] OOF fragmentainer descendant conversions

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
92 Branch
Tracking Status
firefox92 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29604 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29604
Details from upstream follow.

b'Alison Maher <almaher@microsoft.com>' wrote:

[LayoutNG] OOF fragmentainer descendant conversions

If there was no containing block fragment set on an OOF fragmentainer
descendant, we were using an empty size for conversions in
NGPhysicalBoxFragment. This is incorrect - when no containing block is
set, that means the current fragment is the containing block. Use the
size of the current fragment instead.

Additionally, an incorrect converter was used in converting the static
position of OOF fragmentainer descendants in NGPhysicalBoxFragment.
This CL ensures that the static position remains relative to the
containing block, similar to how the conversions are handled in
NGContainerFragmentBuilder.

Bug: 1227115
Change-Id: Idb455573b1bf6b23c80679d8494b56ae267cf34a

Reviewed-on: https://chromium-review.googlesource.com/3011454
WPT-Export-Revision: dbc6646baab8fe62f0af996d90b8aa3c0f8782ee

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 2

Chrome

PASS: 1
FAIL: 1

Safari

PASS: 1
FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/03792f0f5028 [wpt PR 29604] - [LayoutNG] OOF fragmentainer descendant writing-mode conversions, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/75fe6a1a8f2f [wpt PR 29604] - [LayoutNG] OOF fragmentainer descendant writing-mode conversions, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.