Closed Bug 1719593 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29605 - [TransformInterop] Make preserve-3d still be no-op on inlines.

Categories

(Core :: Web Painting, task, P4)

task

Tracking

()

RESOLVED FIXED
92 Branch
Tracking Status
firefox92 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29605 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29605
Details from upstream follow.

b'L. David Baron <dbaron@chromium.org>' wrote:

[TransformInterop] Make preserve-3d still be no-op on inlines.

Make transform-style: preserve-3d still be a no-op on non-replaced
inline elements rather than making it force a stacking context and a
containing block.

This matches Gecko's behavior, and I think the intent of the spec change
that this is implementing. The proposal to change the spec to match is
in https://github.com/w3c/csswg-drafts/issues/6430 .

This change also means we can avoid worrying about fixing the DCHECK()
failures triggered by having an additional way of making non-replaced
inlines be a containing block for fixed-positioned elements.

Fixed: 1226287
Change-Id: Ifeb472de072355001d71f37f3e6bf7c71d085154
Reviewed-on: https://chromium-review.googlesource.com/3011457
WPT-Export-Revision: 159f85145aa3e2cd02fae9a4f10308ee6b4aa423

Component: web-platform-tests → Web Painting
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests

Status Summary

Firefox

PASS: 1[Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-32-qr-opt, Gecko-windows10-64-qr-opt] 2[Gecko-android-em-7.0-x86_64-debug-isolated-process-geckoview] 3[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-windows10-32-qr-debug, Gecko-windows10-64-qr-debug, GitHub]

Chrome

PASS: 3

Safari

PASS: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f3c12cfe47dd [wpt PR 29605] - [TransformInterop] Make preserve-3d still be no-op on inlines., a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/46fc7d1a3281 [wpt PR 29605] - [TransformInterop] Make preserve-3d still be no-op on inlines., a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.