1719736 - mozAccessible protocol should explicitly inherit from NSObject

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P3)

Description

[Morgan Reschenberg [:morgan]]

Right now, mozAccessible the protocol (contained in mozAccessibleProtocol.h) doesn't inherit from NSObject. This causes some problems, namely compiler warnings that NSObject functions are invalid to call on objects implementing the mozAccessible protocol.

For example:

- id<mozAccessible> moxParent { ... }

- void someOtherFunction {
  // the following will throw an error because isKindOfClass is an NSObject function
  if ([[self moxParent] isKindOfClass:[mozActionAccessible class]) { ... }

  // this wont because it implicitly casts id<mozAccessible> to id<NSObject>
  id parent = [self moxParent];
  if ([parent isKindOfClass:[mozActionAccessible class]) { ... }
}

Comment 1

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1719736: Have mozAccessible protocol inherit from NSObject r?eeejay

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e8b4959ef52
Have mozAccessible protocol inherit from NSObject r=eeejay

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1e8b4959ef52