Closed Bug 1719755 Opened 3 years ago Closed 3 years ago

Get sponsored topsites data from Contile by default

Categories

(Firefox :: Top Sites, task)

Product:
Firefox
Component:
Top Sites
Version:
Firefox 91
Platform:
Desktop
All
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox89 --- unaffected
firefox90 --- unaffected
firefox91 --- wontfix
firefox92 --- fixed

People

(Reporter: mythmon, Assigned: mythmon)

References

Details

Attachments

(1 file)

Bug 1719755 - Get sponsored topsites data from Contile by default r=dao
48 bytes, text/x-phabricator-request
Details | Review

According to the Contile rollout plan we want to enable Contile by default starting in Firefox 91.

Pushed by mcooper@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0ceb86d2fcc1
Get sponsored topsites data from Contile by default r=dao,webdriver-reviewers,whimboo

Backed out for xpcshell failures on test_AboutHomeStartupCacheWorker.js with FATAL ERROR: Non-local network connections are disabled and a connection attempt to contile.services.mozilla.com (34.117.237.239) was made.

task 2021-07-19T19:47:44.598Z] 19:47:44     INFO -  TEST-START | browser/components/newtab/test/xpcshell/test_AboutHomeStartupCacheWorker.js
[task 2021-07-19T19:47:47.107Z] 19:47:47  WARNING -  TEST-UNEXPECTED-FAIL | browser/components/newtab/test/xpcshell/test_AboutHomeStartupCacheWorker.js | xpcshell return code: 1
[task 2021-07-19T19:47:47.107Z] 19:47:47     INFO -  TEST-INFO took 2508ms
[task 2021-07-19T19:47:47.107Z] 19:47:47     INFO -  >>>>>>>
[task 2021-07-19T19:47:47.107Z] 19:47:47     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2021-07-19T19:47:47.107Z] 19:47:47     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2021-07-19T19:47:47.107Z] 19:47:47     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2021-07-19T19:47:47.109Z] 19:47:47     INFO -  running event loop
[task 2021-07-19T19:47:47.110Z] 19:47:47     INFO -  browser/components/newtab/test/xpcshell/test_AboutHomeStartupCacheWorker.js | Starting setup
[task 2021-07-19T19:47:47.111Z] 19:47:47     INFO -  (xpcshell/head.js) | test setup pending (2)
[...]
[task 2021-07-19T19:47:47.202Z] 19:47:47     INFO -  PID 16334 | FATAL ERROR: Non-local network connections are disabled and a connection attempt to contile.services.mozilla.com (34.117.237.239) was made.
[task 2021-07-19T19:47:47.202Z] 19:47:47     INFO -  PID 16334 | You should only access hostnames available via the test networking proxy (if running mochitests) or from a test-specific httpd.js server (if running xpcshell tests). Browser services should be disabled or redirected to a local server.
[task 2021-07-19T19:47:47.203Z] 19:47:47     INFO -  PID 16334 | AddressSanitizer:DEADLYSIGNAL
[task 2021-07-19T19:47:47.204Z] 19:47:47     INFO -  PID 16334 | =================================================================
[task 2021-07-19T19:47:47.204Z] 19:47:47    ERROR -  PID 16334 | ==16334==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000001 (pc 0x7f967c4ca153 bp 0x7f9664d160f0 sp 0x7f9664d15920 T4)
[task 2021-07-19T19:47:47.205Z] 19:47:47     INFO -  PID 16334 | ==16334==The signal is caused by a WRITE memory access.
[task 2021-07-19T19:47:47.205Z] 19:47:47     INFO -  PID 16334 | ==16334==Hint: address points to the zero page.
[task 2021-07-19T19:47:47.206Z] 19:47:47     INFO -  PID 16334 |     #0 0x7f967c4ca153 in mozilla::net::nsSocketTransport::InitiateSocket() /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransport2.cpp:1234:7
[task 2021-07-19T19:47:47.207Z] 19:47:47     INFO -  PID 16334 |     #1 0x7f967c4cf3b9 in mozilla::net::nsSocketTransport::OnSocketEvent(unsigned int, nsresult, nsISupports*) /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransport2.cpp:1985:22
[task 2021-07-19T19:47:47.207Z] 19:47:47     INFO -  PID 16334 |     #2 0x7f967c51572a in mozilla::net::nsSocketEvent::Run() /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransport2.cpp:94:17
[task 2021-07-19T19:47:47.208Z] 19:47:47     INFO -  PID 16334 |     #3 0x7f967c185b3b in nsThread::ProcessNextEvent(bool, bool*) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:1142:16
[task 2021-07-19T19:47:47.209Z] 19:47:47     INFO -  PID 16334 |     #4 0x7f967c18ffdc in NS_ProcessNextEvent(nsIThread*, bool) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.cpp:466:10
[task 2021-07-19T19:47:47.209Z] 19:47:47     INFO -  PID 16334 |     #5 0x7f967c4dfb31 in mozilla::net::nsSocketTransportService::Run() /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransportService2.cpp:1167:11
[task 2021-07-19T19:47:47.210Z] 19:47:47     INFO -  PID 16334 |     #6 0x7f967c4e17bc in non-virtual thunk to mozilla::net::nsSocketTransportService::Run() /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransportService2.cpp
[task 2021-07-19T19:47:47.211Z] 19:47:47     INFO -  PID 16334 |     #7 0x7f967c185b3b in nsThread::ProcessNextEvent(bool, bool*) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:1142:16
[task 2021-07-19T19:47:47.211Z] 19:47:47     INFO -  PID 16334 |     #8 0x7f967c18ffdc in NS_ProcessNextEvent(nsIThread*, bool) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.cpp:466:10
[task 2021-07-19T19:47:47.212Z] 19:47:47     INFO -  PID 16334 |     #9 0x7f967d283d08 in mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) /builds/worker/checkouts/gecko/ipc/glue/MessagePump.cpp:300:20
[task 2021-07-19T19:47:47.213Z] 19:47:47     INFO -  PID 16334 |     #10 0x7f967d18fbe1 in RunInternal /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:331:10
[task 2021-07-19T19:47:47.213Z] 19:47:47     INFO -  PID 16334 |     #11 0x7f967d18fbe1 in RunHandler /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:324:3
[task 2021-07-19T19:47:47.214Z] 19:47:47     INFO -  PID 16334 |     #12 0x7f967d18fbe1 in MessageLoop::Run() /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:306:3
[task 2021-07-19T19:47:47.215Z] 19:47:47     INFO -  PID 16334 |     #13 0x7f967c17f5f2 in nsThread::ThreadFunc(void*) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:390:10
[task 2021-07-19T19:47:47.215Z] 19:47:47     INFO -  PID 16334 |     #14 0x7f969352470e in _pt_root /builds/worker/checkouts/gecko/nsprpub/pr/src/pthreads/ptthread.c:201:5
[task 2021-07-19T19:47:47.216Z] 19:47:47     INFO -  PID 16334 |     #15 0x7f969312e6da in start_thread /tmp/glibc/nptl/pthread_create.c:463
[task 2021-07-19T19:47:47.216Z] 19:47:47     INFO -  PID 16334 |     #16 0x7f9675789a3e in clone /tmp/glibc/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:95
[task 2021-07-19T19:47:47.217Z] 19:47:47     INFO -  PID 16334 | AddressSanitizer can not provide additional info.
[task 2021-07-19T19:47:47.218Z] 19:47:47     INFO -  PID 16334 | SUMMARY: AddressSanitizer: SEGV /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransport2.cpp:1234:7 in mozilla::net::nsSocketTransport::InitiateSocket()
[task 2021-07-19T19:47:47.218Z] 19:47:47     INFO -  PID 16334 | Thread T4 (Socket Thread) created by T0 here:
[task 2021-07-19T19:47:47.219Z] 19:47:47     INFO -  PID 16334 |     #0 0x56381f8e0a3c in pthread_create /builds/worker/fetches/llvm-project/llvm/projects/compiler-rt/lib/asan/asan_interceptors.cpp:205:3
[task 2021-07-19T19:47:47.219Z] 19:47:47     INFO -  PID 16334 |     #1 0x7f9693514784 in _PR_CreateThread /builds/worker/checkouts/gecko/nsprpub/pr/src/pthreads/ptthread.c:458:14
[task 2021-07-19T19:47:47.220Z] 19:47:47     INFO -  PID 16334 |     #2 0x7f9693505c5e in PR_CreateThread /builds/worker/checkouts/gecko/nsprpub/pr/src/pthreads/ptthread.c:533:12
[task 2021-07-19T19:47:47.221Z] 19:47:47     INFO -  PID 16334 |     #3 0x7f967c181fba in nsThread::Init(nsTSubstring<char> const&) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:602:18
[task 2021-07-19T19:47:47.221Z] 19:47:47     INFO -  PID 16334 |     #4 0x7f967c18da86 in nsThreadManager::NewNamedThread(nsTSubstring<char> const&, unsigned int, nsIThread**) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadManager.cpp:574:12
[task 2021-07-19T19:47:47.222Z] 19:47:47     INFO -  PID 16334 |     #5 0x7f967c198bc1 in NS_NewNamedThread(nsTSubstring<char> const&, nsIThread**, already_AddRefed<nsIRunnable>, unsigned int) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.cpp:162:57
[task 2021-07-19T19:47:47.223Z] 19:47:47     INFO -  PID 16334 |     #6 0x7f967c4dd4d9 in NS_NewNamedThread<14> /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:85:10
[task 2021-07-19T19:47:47.224Z] 19:47:47     INFO -  PID 16334 |     #7 0x7f967c4dd4d9 in mozilla::net::nsSocketTransportService::Init() /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransportService2.cpp:737:7
[task 2021-07-19T19:47:47.224Z] 19:47:47     INFO -  PID 16334 |     #8 0x7f967c0fe780 in mozilla::xpcom::CreateInstanceImpl(mozilla::xpcom::ModuleID, nsISupports*, nsID const&, void**) /builds/worker/workspace/obj-build/xpcom/components/StaticComponents.cpp:10612:7
[task 2021-07-19T19:47:47.225Z] 19:47:47     INFO -  PID 16334 |     #9 0x7f967c13be53 in CreateInstance /builds/worker/checkouts/gecko/xpcom/components/nsComponentManager.cpp:177:46
[task 2021-07-19T19:47:47.226Z] 19:47:47     INFO -  PID 16334 |     #10 0x7f967c13be53 in nsComponentManagerImpl::GetServiceLocked(mozilla::Maybe<mozilla::MonitorAutoLock>&, (anonymous namespace)::EntryWrapper&, nsID const&, void**) /builds/worker/checkouts/gecko/xpcom/components/nsComponentManager.cpp:1276:17
[task 2021-07-19T19:47:47.227Z] 19:47:47     INFO -  PID 16334 |     #11 0x7f967c13db3d in nsComponentManagerImpl::GetServiceByContractID(char const*, nsID const&, void**) /builds/worker/checkouts/gecko/xpcom/components/nsComponentManager.cpp:1465:10
[task 2021-07-19T19:47:47.227Z] 19:47:47     INFO -  PID 16334 |     #12 0x7f967c142d72 in CallGetService /builds/worker/checkouts/gecko/xpcom/components/nsComponentManagerUtils.cpp:61:43
[task 2021-07-19T19:47:47.228Z] 19:47:47     INFO -  PID 16334 |     #13 0x7f967c142d72 in nsGetServiceByContractIDWithError::operator()(nsID const&, void**) const /builds/worker/checkouts/gecko/xpcom/components/nsComponentManagerUtils.cpp:253:21
[task 2021-07-19T19:47:47.229Z] 19:47:47     INFO -  PID 16334 |     #14 0x7f967bfbb61d in nsCOMPtr_base::assign_from_gs_contractid_with_error(nsGetServiceByContractIDWithError const&, nsID const&) /builds/worker/checkouts/gecko/xpcom/base/nsCOMPtr.cpp:91:7
[task 2021-07-19T19:47:47.229Z] 19:47:47     INFO -  PID 16334 |     #15 0x7f967c43908b in operator= /builds/worker/workspace/obj-build/dist/include/nsCOMPtr.h:774:5
[task 2021-07-19T19:47:47.230Z] 19:47:47     INFO -  PID 16334 |     #16 0x7f967c43908b in mozilla::net::nsIOService::InitializeSocketTransportService() /builds/worker/checkouts/gecko/netwerk/base/nsIOService.cpp:420:29
[task 2021-07-19T19:47:47.231Z] 19:47:47     INFO -  PID 16334 |     #17 0x7f967c437df0 in mozilla::net::nsIOService::SetOffline(bool) /builds/worker/checkouts/gecko/netwerk/base/nsIOService.cpp:1271:7
[task 2021-07-19T19:47:47.232Z] 19:47:47     INFO -  PID 16334 |     #18 0x7f967c435fe7 in mozilla::net::nsIOService::Init() /builds/worker/checkouts/gecko/netwerk/base/nsIOService.cpp:304:3
[task 2021-07-19T19:47:47.232Z] 19:47:47     INFO -  PID 16334 |     #19 0x7f967c439d1b in mozilla::net::nsIOService::GetInstance() /builds/worker/checkouts/gecko/netwerk/base/nsIOService.cpp:477:9
[task 2021-07-19T19:47:47.233Z] 19:47:47     INFO -  PID 16334 |     #20 0x7f967c0eedeb in mozilla::xpcom::CreateInstanceImpl(mozilla::xpcom::ModuleID, nsISupports*, nsID const&, void**) /builds/worker/workspace/obj-build/xpcom/components/StaticComponents.cpp:8740:48
[task 2021-07-19T19:47:47.234Z] 19:47:47     INFO -  PID 16334 |     #21 0x7f967c13be53 in CreateInstance /builds/worker/checkouts/gecko/xpcom/components/nsComponentManager.cpp:177:46
[task 2021-07-19T19:47:47.234Z] 19:47:47     INFO -  PID 16334 |     #22 0x7f967c13be53 in nsComponentManagerImpl::GetServiceLocked(mozilla::Maybe<mozilla::MonitorAutoLock>&, (anonymous namespace)::EntryWrapper&, nsID const&, void**) /builds/worker/checkouts/gecko/xpcom/components/nsComponentManager.cpp:1276:17
[task 2021-07-19T19:47:47.235Z] 19:47:47     INFO -  PID 16334 |     #23 0x7f967c13db3d in nsComponentManagerImpl::GetServiceByContractID(char const*, nsID const&, void**) /builds/worker/checkouts/gecko/xpcom/components/nsComponentManager.cpp:1465:10
[task 2021-07-19T19:47:47.236Z] 19:47:47     INFO -  PID 16334 |     #24 0x7f967de76a77 in CallGetService<nsIIOService> /builds/worker/workspace/obj-build/dist/include/nsServiceManagerUtils.h:52:10
[task 2021-07-19T19:47:47.237Z] 19:47:47     INFO -  PID 16334 |     #25 0x7f967de76a77 in nsScriptSecurityManager::Init() /builds/worker/checkouts/gecko/caps/nsScriptSecurityManager.cpp:1466:17
[task 2021-07-19T19:47:47.237Z] 19:47:47     INFO -  PID 16334 |     #26 0x7f967de76f79 in nsScriptSecurityManager::InitStatics() /builds/worker/checkouts/gecko/caps/nsScriptSecurityManager.cpp:1527:28
[task 2021-07-19T19:47:47.238Z] 19:47:47     INFO -  PID 16334 |     #27 0x7f967dc37100 in nsXPConnect::InitStatics() /builds/worker/checkouts/gecko/js/xpconnect/src/nsXPConnect.cpp:154:3
[task 2021-07-19T19:47:47.239Z] 19:47:47     INFO -  PID 16334 |     #28 0x7f967dbcfe38 in xpcModuleCtor() /builds/worker/checkouts/gecko/js/xpconnect/src/XPCModule.cpp:11:3
[task 2021-07-19T19:47:47.239Z] 19:47:47     INFO -  PID 16334 |     #29 0x7f968402ea1c in nsLayoutModuleInitialize() /builds/worker/checkouts/gecko/layout/build/nsLayoutModule.cpp:100:7
[task 2021-07-19T19:47:47.240Z] 19:47:47     INFO -  PID 16334 |     #30 0x7f967c133c46 in nsComponentManagerImpl::Init() /builds/worker/checkouts/gecko/xpcom/components/nsComponentManager.cpp:408:5
[task 2021-07-19T19:47:47.241Z] 19:47:47     INFO -  PID 16334 |     #31 0x7f967c1f33d7 in NS_InitXPCOM /builds/worker/checkouts/gecko/xpcom/build/XPCOMInit.cpp:446:51
[task 2021-07-19T19:47:47.241Z] 19:47:47     INFO -  PID 16334 |     #32 0x7f967dbfcbcd in XRE_XPCShellMain(int, char**, char**, XREShellData const*) /builds/worker/checkouts/gecko/js/xpconnect/src/XPCShellImpl.cpp:1230:10
[task 2021-07-19T19:47:47.242Z] 19:47:47     INFO -  PID 16334 |     #33 0x56381f92a085 in main /builds/worker/checkouts/gecko/js/xpconnect/shell/xpcshell.cpp:82:27
[task 2021-07-19T19:47:47.243Z] 19:47:47     INFO -  PID 16334 |     #34 0x7f9675689b96 in __libc_start_main /tmp/glibc/csu/../csu/libc-start.c:310
[task 2021-07-19T19:47:47.243Z] 19:47:47     INFO -  PID 16334 | ==16334==ABORTING
Flags: needinfo?(mcooper)
Pushed by mcooper@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/004c99726fda
Get sponsored topsites data from Contile by default r=dao,webdriver-reviewers,whimboo

https://hg.mozilla.org/mozilla-central/rev/004c99726fda

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox92: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
Flags: needinfo?(mcooper)
Regressions: 1721525

What's the status of this bug for Fx91? We built the final beta of the cycle today and next week is RC week.

Flags: needinfo?(mcooper)

We want to not uplift this to Fx91. We're expecting this to go out with Fx92, and it is important it doesn't happen sooner.

Flags: needinfo?(mcooper)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: