1719795 - Change JSCLASS_PRIVATE_IS_NSISUPPORTS uses to use a reserved slot

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jan de Mooij [:jandem]]

We can change JSCLASS_PRIVATE_IS_NSISUPPORTS to JSCLASS_SLOT0_IS_NSISUPPORTS and use a reserved slot for these classes instead.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1719795 part 1 - Add a helper function for getting a SimpleGlobalObject's native global. r?mccr8!

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1719795 part 2 - Use SandboxPrivate::GetPrivate more. r?mccr8!

Depends on D119498

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1719795 part 3 - Inline XPC_WRAPPER_FLAGS. r?mccr8!,jonco!

It's easier to reason about the JSClass flags without the extra level of indirection.

Depends on D119499

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1719795 part 4 - Remove unused AutoClonePrivateGuard. r?mccr8!

Depends on D119500

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1719795 part 5 - Change JSCLASS_PRIVATE_IS_NSISUPPORTS JSClasses to use a reserved slot instead. r?mccr8!,jonco!

This is a step towards removing object private slots.

Classes with JSCLASS_PRIVATE_IS_NSISUPPORTS now use JSCLASS_SLOT0_IS_NSISUPPORTS
instead. For most classes this means we need to add an extra reserved slot and remove
the private slot.

Global objects (SimpleGlobalObject and the XPConnect BackstagePass global) however
can use the JSCLASS_GLOBAL_APPLICATION_SLOTS already there. These slots are only
used for DOM globals.

Depends on D119501

Comment 6

[Jan de Mooij [:jandem]]

Attachment: Bug 1719795 part 6 - Remove null check for JS::GetClass return value. r?mccr8!

Every JSObject has a non-null JSClass and a lot of code depends on this.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/202535112cbd
part 1 - Add a helper function for getting a SimpleGlobalObject's native global. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/cebc11755de6
part 2 - Use SandboxPrivate::GetPrivate more. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/bd12f699ea33
part 3 - Inline XPC_WRAPPER_FLAGS. r=jonco,peterv
https://hg.mozilla.org/integration/autoland/rev/69fbadc353c3
part 4 - Remove unused AutoClonePrivateGuard. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/991fd9b37ce8
part 5 - Change JSCLASS_PRIVATE_IS_NSISUPPORTS JSClasses to use a reserved slot instead. r=mccr8,jonco
https://hg.mozilla.org/integration/autoland/rev/fe76633b0f3b
part 6 - Remove null check for JS::GetClass return value. r=mccr8

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/202535112cbd
https://hg.mozilla.org/mozilla-central/rev/cebc11755de6
https://hg.mozilla.org/mozilla-central/rev/bd12f699ea33
https://hg.mozilla.org/mozilla-central/rev/69fbadc353c3
https://hg.mozilla.org/mozilla-central/rev/991fd9b37ce8
https://hg.mozilla.org/mozilla-central/rev/fe76633b0f3b